[Refactoring] Remove finish() from all CodeGenerator*.pm
authorharaken@chromium.org <haraken@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Jan 2012 19:25:00 +0000 (19:25 +0000)
committerharaken@chromium.org <haraken@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Jan 2012 19:25:00 +0000 (19:25 +0000)
https://bugs.webkit.org/show_bug.cgi?id=76918

Reviewed by Darin Adler.

Now finish() is empty in all CodeGenerator*.pm. This patch removes them.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(ProcessDocument):
* bindings/scripts/CodeGeneratorCPP.pm:
* bindings/scripts/CodeGeneratorGObject.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/bindings/scripts/CodeGenerator.pm
Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm
Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm
Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

index 744a792..3009797 100644 (file)
@@ -1,3 +1,22 @@
+2012-01-24  Kentaro Hara  <haraken@chromium.org>
+
+        [Refactoring] Remove finish() from all CodeGenerator*.pm
+        https://bugs.webkit.org/show_bug.cgi?id=76918
+
+        Reviewed by Darin Adler.
+
+        Now finish() is empty in all CodeGenerator*.pm. This patch removes them.
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGenerator.pm:
+        (ProcessDocument):
+        * bindings/scripts/CodeGeneratorCPP.pm:
+        * bindings/scripts/CodeGeneratorGObject.pm:
+        * bindings/scripts/CodeGeneratorJS.pm:
+        * bindings/scripts/CodeGeneratorObjC.pm:
+        * bindings/scripts/CodeGeneratorV8.pm:
+
 2012-01-24  Vsevolod Vlasov  <vsevik@chromium.org>
 
         Web Inspector: incorrect highlight position when searching in console
index 44fefde..c399d6e 100644 (file)
@@ -147,8 +147,6 @@ sub ProcessDocument
         print "Generating $useGenerator bindings code for IDL interface \"" . $class->name . "\"...\n" if $verbose;
         $codeGenerator->GenerateInterface($class, $defines);
     }
-
-    $codeGenerator->finish();
 }
 
 sub FileNamePrefix
index 6966d90..6c68461 100644 (file)
@@ -107,11 +107,6 @@ sub new
     return $reference;
 }
 
-sub finish
-{
-    my $object = shift;
-}
-
 # Params: 'domClass' struct
 sub GenerateInterface
 {
index 702e8e6..b2e60dd 100644 (file)
@@ -51,9 +51,6 @@ sub new {
     bless($reference, $object);
 }
 
-sub finish {
-}
-
 my $licenceTemplate = << "EOF";
 /*
     This file is part of the WebKit open source project.
index 426277e..2f9eedb 100644 (file)
@@ -88,12 +88,6 @@ sub new
     return $reference;
 }
 
-# FIXME(haraken): finish() will be soon removed from all CodeGenerators.
-sub finish
-{
-    my $object = shift;
-}
-
 sub leftShift($$) {
     my ($value, $distance) = @_;
     return (($value << $distance) & 0xFFFFFFFF);
index 6cb1fcb..113f8b3 100644 (file)
@@ -208,11 +208,6 @@ sub new
     return $reference;
 }
 
-sub finish
-{
-    my $object = shift;
-}
-
 sub ReadPublicInterfaces
 {
     my $class = shift;
index 4d34d2a..82715a3 100644 (file)
@@ -85,12 +85,6 @@ sub new
     return $reference;
 }
 
-# FIXME(haraken): finish() will be soon removed from all CodeGenerators.
-sub finish
-{
-    my $object = shift;
-}
-
 # Params: 'domClass' struct
 sub GenerateInterface
 {