Reviewed by John H.
authoroliver <oliver@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Aug 2007 07:24:45 +0000 (07:24 +0000)
committeroliver <oliver@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Aug 2007 07:24:45 +0000 (07:24 +0000)
        WebDataSource::response can legitimately have a null response, so we
        must check that case.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
        (queueLoadCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp

index e5bbc52f6c4b593130d8007e67b32c093cefd882..ebbf28e176c7e0690bdccd53cbef933fd49c5dba 100644 (file)
@@ -1,3 +1,13 @@
+2007-08-24  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by John H.
+
+        WebDataSource::response can legitimately have a null response, so we
+        must check that case.
+
+        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
+        (queueLoadCallback):
+
 2007-08-23  Mitz Pettel  <mitz@webkit.org>
 
         Reviewed by Darin and Adam.
index 8ece1bdc991cf13cd5b67a28a2a89f854f6d616e..c67905b8eaf3ca7975eb66ea30ff1da394f1089d 100644 (file)
@@ -233,7 +233,7 @@ static JSValueRef queueLoadCallback(JSContextRef context, JSObjectRef function,
         return undefined;
 
     COMPtr<IWebURLResponse> response;
-    if (FAILED(dataSource->response(&response)))
+    if (FAILED(dataSource->response(&response)) || !response)
         return undefined;
 
     BSTR responseURLBSTR;