2008-02-04 Jon Honeycutt <jhoneycutt@apple.com>
authorjhoneycutt@apple.com <jhoneycutt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Feb 2008 22:15:54 +0000 (22:15 +0000)
committerjhoneycutt@apple.com <jhoneycutt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Feb 2008 22:15:54 +0000 (22:15 +0000)
        Reviewed by Darin.

        Blacklist Silverlight versions older than min required, not newer.

        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackageWin::isPluginBlacklisted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/plugins/win/PluginPackageWin.cpp

index 67c4867ddb08c1a2817b14afe9d2c18ee4bd2aec..9f442bff02fda8e7280fccc21fe7503a4f4a3320 100644 (file)
@@ -1,3 +1,12 @@
+2008-02-04  Jon Honeycutt  <jhoneycutt@apple.com>
+
+        Reviewed by Darin.
+
+        Blacklist Silverlight versions older than min required, not newer. 
+
+        * plugins/win/PluginPackageWin.cpp:
+        (WebCore::PluginPackageWin::isPluginBlacklisted):
+
 2008-02-04  David Hyatt  <hyatt@apple.com>
 
         Fix for bug 16751, misparsing of html*.test in CSS.
index 8f37d725a728f484f3f6bbc26b0a9340dda068af..cf53742fa8620f1b942b2670c6986fb4aa19af96 100644 (file)
@@ -145,7 +145,7 @@ bool PluginPackageWin::isPluginBlacklisted()
         // workaround for <rdar://5557379> Crash in Silverlight when opening microsoft.com.
         // the latest 1.0 version of Silverlight does not reproduce this crash, so allow it
         // and any newer versions
-        if (compareFileVersion(silverlightPluginMinRequiredVersionMS, silverlightPluginMinRequiredVersionLS) >= 0)
+        if (compareFileVersion(silverlightPluginMinRequiredVersionMS, silverlightPluginMinRequiredVersionLS) < 0)
             return true;
     } else if (fileName() == "npmozax.dll")
         // Bug 15217: Mozilla ActiveX control complains about missing xpcom_core.dll