2006-09-13 Mark Rowe <opendarwin.org@bdash.net.nz>

        Reviewed by Adam.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
        Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller

        * platform/mac/FileChooserMac.mm:
        (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 3755d0633aa35020b778935ae32b0c1c45d5277f..353102d985ac80102b7837d7933a75a3d10b36c5 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,13 @@
+2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
+
+        Reviewed by Adam.
+
+        http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
+        Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller
+
+        * platform/mac/FileChooserMac.mm:
+        (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.
+
 2006-09-13  Mark Rowe  <opendarwin.org@bdash.net.nz>
 
         Reviewed by Eric.

diff --git a/WebCore/platform/mac/FileChooserMac.mm b/WebCore/platform/mac/FileChooserMac.mm
index c51bd1ccdffa641abb2369feccb3d50c1d53d46c..eb8bbe4ca1f3d4d95c02bf9050c5640b1dce18dd 100644 (file)
--- a/WebCore/platform/mac/FileChooserMac.mm
+++ b/WebCore/platform/mac/FileChooserMac.mm
@@ -89,7 +89,7 @@ FileChooser::FileChooser(Document* document, RenderFileUploadControl* uploadCont
     : m_document(document)
     , m_icon(0)
     , m_uploadControl(uploadControl)
-    , m_controller([[[OpenPanelController alloc] initWithFileChooser:this] retain])
+    , m_controller([[OpenPanelController alloc] initWithFileChooser:this])
 {
 }