WebKit:
authorsullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 14 Apr 2004 20:39:56 +0000 (20:39 +0000)
committersullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 14 Apr 2004 20:39:56 +0000 (20:39 +0000)
        - changed stealth mode preference name from "historyIsFrozen"
        to "privateBrowsingEnabled"

        Reviewed by Darin.

        * WebView.subproj/WebFrame.m:
        (-[WebFrame _transitionToCommitted:]):
        updated for method name change

        * WebView.subproj/WebPreferences.m:
        changed preference key name
        (+[WebPreferences initialize]):
        updated for preference key name change
        (-[WebPreferences setPrivateBrowsingEnabled:]):
        changed name from setHistoryIsFrozen:
        (-[WebPreferences privateBrowsingEnabled]):
        changed name from historyIsFrozen:

        * WebView.subproj/WebPreferencesPrivate.h:
        changed declared method names

        * English.lproj/StringsNotToBeLocalized.txt:
        updated for this and other recent changes

WebBrowser:

        fixed these bugs:
        <rdar://problem/3622190>: stealth mode menu item should be "Start Private Browsing�Stop Private Browsing"
        <rdar://problem/3622479>: Reword Private Browsing confirmation to use Ron's edited wording
        <rdar://problem/3622496>: stealth mode should automatically turn off between sessions

        Also, updated for WebKit stealth mode preference name change

        Reviewed by Darin.

        * AppController.m:
        (-[AppController applicationDidFinishLaunching:]):
        always turn off stealth mode on launch (previously did this only on Panther)
        (-[AppController confirmEnableStealthMode]):
        reworded confirmation title and message; also updated for preference name change
        (-[AppController toggleStealthMode:]):
        updated for preference name change
        (-[AppController validateUserInterfaceItem:]):
        use "Start/Stop" instead of checkmark to distinguish states; also updated for
        preference name change

        * BrowserWindowController.m:
        (-[BrowserWindowController searchField:shouldRememberSearchString:]):
        updated for preference name change

        * DownloadProgressEntry.m:
        (-[DownloadProgressEntry setDownloadStage:]):
        updated for preference name change

        * English.lproj/Localizable.strings:
        * English.lproj/StringsNotToBeLocalized.txt:
        updated for these changes

        * English.lproj/MainMenu.nib:
        changed menu item in the nib to "Start Private Browsing�, though this
        doesn't really matter since the toggling menu item title comes from the code now.

        * FormCompletionController.m:
        (+[FormCompletionController shouldSaveFormData]):
        updated for preference name change
        (+[FormCompletionController shouldSaveUsernamesAndPasswords]):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@6374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/English.lproj/StringsNotToBeLocalized.txt
WebKit/WebView.subproj/WebFrame.m
WebKit/WebView.subproj/WebPreferences.m
WebKit/WebView.subproj/WebPreferencesPrivate.h

index 30e40d90fa327d35a7ca11968235c00abf93d7c6..e785c6cda21bd4c5dc0b9e5be5a7a7517deb0678 100644 (file)
@@ -1,3 +1,29 @@
+2004-04-14  John Sullivan  <sullivan@apple.com>
+
+        - changed stealth mode preference name from "historyIsFrozen"
+        to "privateBrowsingEnabled"
+
+        Reviewed by Darin.
+
+        * WebView.subproj/WebFrame.m:
+        (-[WebFrame _transitionToCommitted:]):
+        updated for method name change
+        
+        * WebView.subproj/WebPreferences.m:
+        changed preference key name
+        (+[WebPreferences initialize]):
+        updated for preference key name change
+        (-[WebPreferences setPrivateBrowsingEnabled:]):
+        changed name from setHistoryIsFrozen:
+        (-[WebPreferences privateBrowsingEnabled]):
+        changed name from historyIsFrozen:
+        
+        * WebView.subproj/WebPreferencesPrivate.h:
+        changed declared method names
+
+        * English.lproj/StringsNotToBeLocalized.txt:
+        updated for this and other recent changes
+
 2004-04-13  Chris Blumenberg  <cblu@apple.com>
 
        - Added WebElementDOMNodeKey as a potential API so that clients can get the node from an element dictionary.
index a527ea6c2a6ea18a1cd7e7889396291d6f6199a2..164855ffa61f9a353980095a69baf318ccbe58f2 100644 (file)
 "WebBackForwardList:\n"
 "WebCurrentFrameState"
 "WebDataRequest"
+"WebElementDOMNode"
 "WebElementFrame"
 "WebElementImage"
 "WebElementImageAltString"
 "WebElementImageRect"
 "WebElementImageURL"
-"WebElementIsEditable"
 "WebElementIsSelected"
 "WebElementLinkLabel"
 "WebElementLinkTitle"
 "WebKitFantasyFont"
 "WebKitFixedFont"
 "WebKitHistoryAgeInDaysLimit"
-"WebKitHistoryIsFrozen"
 "WebKitHistoryItemLimit"
 "WebKitInitialTimedLayoutDelay"
 "WebKitInitialTimedLayoutEnabled"
 "WebKitObjectCacheSizePreferenceKey"
 "WebKitPageCacheSizePreferenceKey"
 "WebKitPluginsEnabled"
+"WebKitPrivateBrowsingEnabled"
 "WebKitResourceTimedLayoutDelay"
 "WebKitResourceTimedLayoutEnabled"
 "WebKitSansSerifFont"
index 64ec3ec31a50724477749f5465e0d223b0c54502..b7e3684ca62603ef7d1810f49b1e6c58ea15ad8f 100644 (file)
@@ -785,7 +785,7 @@ NSString *WebPageCacheDocumentViewKey = @"WebPageCacheDocumentViewKey";
                     // Add item to history and BF list
                     NSURL *URL = [ds _URLForHistory];
                     if (URL && ![URL _web_isEmpty]){
-                        if (![[WebPreferences standardPreferences] historyIsFrozen]) {
+                        if (![[WebPreferences standardPreferences] privateBrowsingEnabled]) {
                             entry = [[WebHistory optionalSharedHistory] addItemForURL:URL];
                             if (ptitle)
                                 [entry setTitle: ptitle];                            
index 249903a551eaa1b19a74a0eeaae4feb01578f12e..47fcb73c189b8fd940867a9acce633d48f092efb 100644 (file)
@@ -46,7 +46,7 @@
 #define WebKitObjectCacheSizePreferenceKey @"WebKitObjectCacheSizePreferenceKey"
 #define WebKitBackForwardCacheExpirationIntervalKey @"WebKitBackForwardCacheExpirationIntervalKey"
 #define WebKitTabToLinksPreferenceKey @"WebKitTabToLinksPreferenceKey"
-#define WebKitHistoryIsFrozenPreferenceKey @"WebKitHistoryIsFrozen"
+#define WebKitPrivateBrowsingEnabledPreferenceKey @"WebKitPrivateBrowsingEnabled"
 
 NSString *WebPreferencesChangedNotification = @"WebPreferencesChangedNotification";
 
@@ -235,7 +235,7 @@ NS_ENDHANDLER
         [NSNumber numberWithBool:YES],  WebKitDisplayImagesKey,
         @"1800",                        WebKitBackForwardCacheExpirationIntervalKey,
         [NSNumber numberWithBool:NO],   WebKitTabToLinksPreferenceKey,
-        [NSNumber numberWithBool:NO],   WebKitHistoryIsFrozenPreferenceKey,
+        [NSNumber numberWithBool:NO],   WebKitPrivateBrowsingEnabledPreferenceKey,
         nil];
 
     [[NSUserDefaults standardUserDefaults] registerDefaults:dict];
@@ -610,14 +610,14 @@ NS_ENDHANDLER
     return [[NSUserDefaults standardUserDefaults] boolForKey:WebKitTabToLinksPreferenceKey];
 }
 
-- (void)setHistoryIsFrozen:(BOOL)flag
+- (void)setPrivateBrowsingEnabled:(BOOL)flag
 {
-    [self _setBoolValue:flag forKey:WebKitHistoryIsFrozenPreferenceKey];
+    [self _setBoolValue:flag forKey:WebKitPrivateBrowsingEnabledPreferenceKey];
 }
 
-- (BOOL)historyIsFrozen
+- (BOOL)privateBrowsingEnabled
 {
-    return [[NSUserDefaults standardUserDefaults] boolForKey:WebKitHistoryIsFrozenPreferenceKey];
+    return [[NSUserDefaults standardUserDefaults] boolForKey:WebKitPrivateBrowsingEnabledPreferenceKey];
 }
 
 static NSMutableDictionary *webPreferencesInstances = nil;
index 3876c1e8434c6570dc5c9b448054da2167048175..2d3d2a4c6214e74c17642f7c050ba025240ce74e 100644 (file)
@@ -22,8 +22,8 @@
 
 + (void)_setIBCreatorID:(NSString *)string;
 
-- (void)setHistoryIsFrozen:(BOOL)newValue;
-- (BOOL)historyIsFrozen;
+- (void)setPrivateBrowsingEnabled:(BOOL)newValue;
+- (BOOL)privateBrowsingEnabled;
 
 - (void)setTabsToLinks:(BOOL)flag;
 - (BOOL)tabsToLinks;