2011-05-15 Robert Hogan <robert@webkit.org>
authorloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 16 May 2011 09:50:41 +0000 (09:50 +0000)
committerloislo@chromium.org <loislo@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 16 May 2011 09:50:41 +0000 (09:50 +0000)
        Reviewed by Yury Semikhatsky.

        [Qt] Fix crash in inspector/console/console-long-eval-crash.html
        https://bugs.webkit.org/show_bug.cgi?id=60858

        The client may be gone when sendMessageToBackend() is called.

        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::sendMessageToBackend):

2011-05-16  Robert Hogan  <robert@webkit.org>

        Reviewed by Yury Semikhatsky.

        [Qt] Fix crash in inspector/console/console-long-eval-crash.html
        https://bugs.webkit.org/show_bug.cgi?id=60858

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/qt/Skipped
Source/WebCore/ChangeLog
Source/WebCore/inspector/InspectorFrontendHost.cpp

index cf58f9cd33231820138eb4e81b3183650552978e..6e68ad73e2f12642f401fbfa75b1b006c053f87c 100644 (file)
@@ -1,3 +1,12 @@
+2011-05-16  Robert Hogan  <robert@webkit.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        [Qt] Fix crash in inspector/console/console-long-eval-crash.html
+        https://bugs.webkit.org/show_bug.cgi?id=60858
+
+        * platform/qt/Skipped:
+
 2011-05-16  Gavin Barraclough  <barraclough@apple.com>
 
         Rubber stamped by Geoff Garen.
index 4070fd569793c05ae4601be55da847a09f4bebd8..f2601bcd3f9cd921b4d74ff056e71e6a18bba5c2 100644 (file)
@@ -107,9 +107,6 @@ inspector/debugger/dom-breakpoints.html
 inspector/debugger/event-listener-breakpoints.html
 inspector/debugger/xhr-breakpoints.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=60616
-inspector/console/console-long-eval-crash.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=40300
 inspector/debugger/live-edit.html
 
index d37012a44e247c139926c233441bfadf74544d39..f438b729f3f75df661371e065cebbf4619d2f797 100644 (file)
@@ -1,3 +1,15 @@
+2011-05-15  Robert Hogan  <robert@webkit.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        [Qt] Fix crash in inspector/console/console-long-eval-crash.html
+        https://bugs.webkit.org/show_bug.cgi?id=60858
+
+        The client may be gone when sendMessageToBackend() is called.
+
+        * inspector/InspectorFrontendHost.cpp:
+        (WebCore::InspectorFrontendHost::sendMessageToBackend):
+
 2011-05-16  Nikolas Zimmermann  <nzimmermann@rim.com>
 
         Reviewed by Dirk Schulze.
index d7f16a976ccbac0f2184d91f408c1012c11f9ed2..004e457a71a326b75c771567fa9f94a4c1e25bce 100644 (file)
@@ -242,7 +242,8 @@ String InspectorFrontendHost::loadSessionSetting(const String& key)
 
 void InspectorFrontendHost::sendMessageToBackend(const String& message)
 {
-    m_client->sendMessageToBackend(message);
+    if (m_client)
+        m_client->sendMessageToBackend(message);
 }
 
 #if ENABLE(CONTEXT_MENUS)