2007-12-19 Sven Herzberg <sven@imendio.com>
authoralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Dec 2007 03:03:43 +0000 (03:03 +0000)
committeralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Dec 2007 03:03:43 +0000 (03:03 +0000)
        Reviewed by Alp Toker.

        Scaled font destruction takes place in FontData::platformDestroy(). No
        need to do it in FontPlatformData::~FontPlatformData().

        Destroying platform data in platformDestroy() is a convention we
        borrow from the Mac and Win ports.

        * platform/graphics/gtk/FontPlatformDataGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp

index bb1f1002e568091d27420628b9102e92c5a78262..1d61eaa532f91eed59f71c6caf108c2acfb43da9 100644 (file)
@@ -1,3 +1,15 @@
+2007-12-19  Sven Herzberg  <sven@imendio.com>
+
+        Reviewed by Alp Toker.
+
+        Scaled font destruction takes place in FontData::platformDestroy(). No
+        need to do it in FontPlatformData::~FontPlatformData().
+
+        Destroying platform data in platformDestroy() is a convention we
+        borrow from the Mac and Win ports.
+
+        * platform/graphics/gtk/FontPlatformDataGtk.cpp:
+
 2007-12-19  Alice Liu  <alice.liu@apple.com>
 
         build fix (Windows)
index 37ad20a9a074615d648f6b4a545280901e468264..6c20c5e9ef1e872df8eb093649756913c1c5b0ec 100644 (file)
@@ -158,8 +158,7 @@ bool FontPlatformData::init()
 
 FontPlatformData::~FontPlatformData()
 {
-    if (m_scaledFont)
-        cairo_scaled_font_destroy(m_scaledFont);
+    // Destroy takes place in FontData::platformDestroy().
 }
 
 bool FontPlatformData::isFixedPitch()