LayoutTests:
authordarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Apr 2006 16:49:04 +0000 (16:49 +0000)
committerdarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 10 Apr 2006 16:49:04 +0000 (16:49 +0000)
        - regenerated pixel results because many may be affected by
          the fix for bug 8100

WebKit:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8100
          REGRESSION (NativeTextField): Right-aligned and RTL text jitters in new text fields

        * WebCoreSupport/WebTextRenderer.m:
        (overrideLayoutOperation): For RTL runs, apply the word-rounding on the left.
        (CG_floatWidthForRun): For RTL runs, apply the last character's rounding
        on the left by adjusting the start position.
        (initializeWidthIterator): Added finalRoundingWidth field to WidthIterator.
        (advanceWidthIterator): For RTL runs, apply rounding on the left of the character,
        by increasing the width of the next character (which is the character to the left). For
        the last character, keep the rounding width in the iterator's finalRoundingWidth, to be used by
        CG_floatWidthForRun().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

92 files changed:
LayoutTests/ChangeLog
LayoutTests/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum
LayoutTests/css2.1/t0804-c5510-padn-00-b-ag-expected.png
LayoutTests/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum
LayoutTests/css2.1/t100801-c544-valgn-02-d-agi-expected.png
LayoutTests/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum
LayoutTests/css2.1/t100801-c544-valgn-03-d-agi-expected.png
LayoutTests/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum
LayoutTests/css2.1/t100801-c544-valgn-04-d-agi-expected.png
LayoutTests/editing/selection/caret-rtl-2-expected.checksum
LayoutTests/editing/selection/caret-rtl-2-expected.png
LayoutTests/editing/selection/caret-rtl-expected.checksum
LayoutTests/editing/selection/caret-rtl-expected.png
LayoutTests/fast/css/rtl-ordering-expected.checksum
LayoutTests/fast/css/rtl-ordering-expected.png
LayoutTests/fast/forms/visual-hebrew-text-field-expected.checksum
LayoutTests/fast/forms/visual-hebrew-text-field-expected.png
LayoutTests/fast/replaced/image-sizing-expected.checksum
LayoutTests/fast/replaced/image-sizing-expected.png
LayoutTests/fast/replaced/maxheight-percent-expected.checksum
LayoutTests/fast/replaced/maxheight-percent-expected.png
LayoutTests/fast/replaced/maxheight-pxs-expected.checksum
LayoutTests/fast/replaced/maxheight-pxs-expected.png
LayoutTests/fast/replaced/maxwidth-percent-expected.checksum
LayoutTests/fast/replaced/maxwidth-percent-expected.png
LayoutTests/fast/replaced/maxwidth-pxs-expected.checksum
LayoutTests/fast/replaced/maxwidth-pxs-expected.png
LayoutTests/fast/text/atsui-spacing-features-expected.checksum
LayoutTests/fast/text/atsui-spacing-features-expected.png
LayoutTests/fast/text/in-rendered-text-rtl-expected.checksum
LayoutTests/fast/text/in-rendered-text-rtl-expected.png
LayoutTests/fast/text/international/bidi-AN-after-L-expected.checksum
LayoutTests/fast/text/international/bidi-AN-after-L-expected.png
LayoutTests/fast/text/international/bidi-L2-run-reordering-expected.checksum
LayoutTests/fast/text/international/bidi-L2-run-reordering-expected.png
LayoutTests/fast/text/international/bidi-LDB-2-CSS-expected.checksum
LayoutTests/fast/text/international/bidi-LDB-2-CSS-expected.png
LayoutTests/fast/text/international/bidi-LDB-2-HTML-expected.checksum
LayoutTests/fast/text/international/bidi-LDB-2-HTML-expected.png
LayoutTests/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum
LayoutTests/fast/text/international/bidi-LDB-2-formatting-characters-expected.png
LayoutTests/fast/text/international/bidi-european-terminators-expected.checksum
LayoutTests/fast/text/international/bidi-european-terminators-expected.png
LayoutTests/fast/text/international/bidi-explicit-embedding-expected.checksum
LayoutTests/fast/text/international/bidi-explicit-embedding-expected.png
LayoutTests/fast/text/international/bidi-fallback-font-weight-expected.checksum
LayoutTests/fast/text/international/bidi-fallback-font-weight-expected.png
LayoutTests/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum
LayoutTests/fast/text/international/bidi-ignored-for-first-child-inline-expected.png
LayoutTests/fast/text/international/bidi-innertext-expected.checksum
LayoutTests/fast/text/international/bidi-innertext-expected.png
LayoutTests/fast/text/international/bidi-layout-across-linebreak-expected.checksum
LayoutTests/fast/text/international/bidi-layout-across-linebreak-expected.png
LayoutTests/fast/text/international/bidi-override-expected.checksum
LayoutTests/fast/text/international/bidi-override-expected.png
LayoutTests/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-color-01-b-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-example-01-b-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-image-01-b-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-light-01-f-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png
LayoutTests/svg/custom/feDisplacementMap-01-expected.checksum
LayoutTests/svg/custom/feDisplacementMap-01-expected.png
LayoutTests/svg/custom/filter-source-alpha-expected.checksum
LayoutTests/svg/custom/filter-source-alpha-expected.png
LayoutTests/svg/custom/image-with-transform-clip-filter-expected.checksum
LayoutTests/svg/custom/image-with-transform-clip-filter-expected.png
LayoutTests/svg/custom/inner-percent-expected.checksum
LayoutTests/svg/custom/text-filter-expected.checksum
LayoutTests/svg/custom/text-filter-expected.png
LayoutTests/svg/custom/text-image-opacity-expected.checksum
LayoutTests/svg/custom/text-image-opacity-expected.png
WebKit/ChangeLog
WebKit/WebCoreSupport/WebTextRenderer.m

index d540370d5a5c5fccb9d13b0ba598140ccdce98cd..f4044e110f55c3760f8da9442a66aa9fd3b2ddfc 100644 (file)
@@ -1,3 +1,8 @@
+2006-04-10  Darin Adler  <darin@apple.com>
+
+        - regenerated pixel results because many may be affected by
+          the fix for bug 8100
+
 2006-04-09  Alexey Proskuryakov  <ap@nypop.com>
 
         Reviewed by Darin.
index a5140418df0bbec0c533d263f9c41086b840fa4f..dff1f15351a82e18f00944b4b254134fee7e31f0 100644 (file)
@@ -1 +1 @@
-ed0cd9f249add4565fccd63c159f8461
\ No newline at end of file
+5a270447e032240da939d66ef8e9f391
\ No newline at end of file
index ac2f184842c4d638a02778ff9ec9ba8b43d02ec2..8aca95f93a6b937b08a3c8339adc3e1695cfe962 100644 (file)
Binary files a/LayoutTests/css2.1/t0804-c5510-padn-00-b-ag-expected.png and b/LayoutTests/css2.1/t0804-c5510-padn-00-b-ag-expected.png differ
index 1cece9db6a97a52b15721f0f95bc86ca6020ccb6..41f80d4022c11b1417828d7100ed56e09c63852c 100644 (file)
@@ -1 +1 @@
-e754c35fb21f899b6443307e940c189f
\ No newline at end of file
+0f03e81c2beaed5a3445f52bbc1de765
\ No newline at end of file
index 3eff3961abd92e4102326315b3497bb20724ad3d..917c918f7d41fcadb4506dd97b9ec1ec06b8ec0f 100644 (file)
Binary files a/LayoutTests/css2.1/t100801-c544-valgn-02-d-agi-expected.png and b/LayoutTests/css2.1/t100801-c544-valgn-02-d-agi-expected.png differ
index 50f422e82735f518685a0e5fdd42a68e340289f7..fa297f12031e043272f3dd8270202a061a3d0047 100644 (file)
@@ -1 +1 @@
-51313f66ad2b86e86fcc982cf9e6f4d3
\ No newline at end of file
+d81f2e236082678d5aee5470e8efa4ed
\ No newline at end of file
index 0783d56d26d378b78adc0275557059fdaf6772cc..36450ce118637ac1d0593cf2c0d1715e4601bb4d 100644 (file)
Binary files a/LayoutTests/css2.1/t100801-c544-valgn-03-d-agi-expected.png and b/LayoutTests/css2.1/t100801-c544-valgn-03-d-agi-expected.png differ
index 20b84adb51b5b8b5929799dee8aa7f4d270c3cdc..368b620d5c2b30c03f3277c0ad71cb2ebbeaa4a7 100644 (file)
@@ -1 +1 @@
-3a8ed14f5b35c7723304b6f81486e1dd
\ No newline at end of file
+8fc73a08382b8ef93ae9b0ace0a9d849
\ No newline at end of file
index 57324e2ff1f2638c792a20741d9a49b911332cae..0a770177c6099773953f70afe9b86b2264119f20 100644 (file)
Binary files a/LayoutTests/css2.1/t100801-c544-valgn-04-d-agi-expected.png and b/LayoutTests/css2.1/t100801-c544-valgn-04-d-agi-expected.png differ
index fb45e79a6b4282dae5502c7afb575f291dd6b013..920ffec39dae94eab3ca82075b1e4e509f058d00 100644 (file)
@@ -1 +1 @@
-0469b8fccf17f3df252e64a69b637346
\ No newline at end of file
+20161f4abb8fd763a03fb02dd8f8decc
\ No newline at end of file
index c77e7f0efe9fb255a75350e7c790465db8f5b43f..0f3e97250fc58689273df6b4540a25226f270ee1 100644 (file)
Binary files a/LayoutTests/editing/selection/caret-rtl-2-expected.png and b/LayoutTests/editing/selection/caret-rtl-2-expected.png differ
index 0a776418f23a5952211ee9f525fb8e327865b403..fa8d7a8474790e327be99e3a8d9472d27e6ee689 100644 (file)
@@ -1 +1 @@
-cdd88ee6dd6cdd32a9d5e46847a641d6
\ No newline at end of file
+caa77a9907fce257c36d4b4a8e6f7f11
\ No newline at end of file
index f671274a8e47cd579466ae518593ad6758bc908e..ce35e7ab097f5e0865f9158489218e9602ce6f37 100644 (file)
Binary files a/LayoutTests/editing/selection/caret-rtl-expected.png and b/LayoutTests/editing/selection/caret-rtl-expected.png differ
index 1e2d03f5633c6df291482add70f3a10ed8aa0157..5a0d9e089ef330f5e2b293b6c160479172830cbc 100644 (file)
@@ -1 +1 @@
-9c65ee2638acb2f6f55e3e64601fe4c3
\ No newline at end of file
+bd1e473744edd3d5578e2a994da56008
\ No newline at end of file
index d4c7d6a0ae371425552e161277c4540e3dfd197f..cecfdc8d47a05d97340480b4153e4a7b49be663a 100644 (file)
Binary files a/LayoutTests/fast/css/rtl-ordering-expected.png and b/LayoutTests/fast/css/rtl-ordering-expected.png differ
index 0a3b8b9ed24ab9181020c8c67181db8af4029f76..f91a150dfa6997432d614804971531c096f198d3 100644 (file)
@@ -1 +1 @@
-9acedc4dd566f3b1d8e64c953cefb40d
\ No newline at end of file
+49579c38e96ac74f34874645e86ae08c
\ No newline at end of file
index 5627d42c953455976ee79722bea32f04237d7e1f..28aac040e82a4b687490dee0e98bc857c7734ae1 100644 (file)
Binary files a/LayoutTests/fast/forms/visual-hebrew-text-field-expected.png and b/LayoutTests/fast/forms/visual-hebrew-text-field-expected.png differ
index d13e5fc33e9916a1b776688d1e1ebfe718c1e346..1d2ea803004abbe1941846b8faf56155d493caa3 100644 (file)
@@ -1 +1 @@
-9648e9aed27fb9477f405026b40182a9
\ No newline at end of file
+8ee98bac9fe22adec53bd8a5add75037
\ No newline at end of file
index a488bbe7b20dff51ecf1faeefc8f0b168d3c2cda..d6028e454e8e38cbafff5d7fa86fed115c8e23b2 100644 (file)
Binary files a/LayoutTests/fast/replaced/image-sizing-expected.png and b/LayoutTests/fast/replaced/image-sizing-expected.png differ
index b1fff3285ead7c6f97f1e85fe46993154a642425..41a983d14656039484d3fb701253bae51aa7e2e2 100644 (file)
@@ -1 +1 @@
-fe2d339b2341cf44ce28384f8fe214d4
\ No newline at end of file
+44e1a11632ef14e6c92b95c8cf24ee67
\ No newline at end of file
index 85f781c48e625fe74a939c2f6d56c22487d2506b..a6a161c7c8e0c5792509a8aa7ff3964def49fa69 100644 (file)
Binary files a/LayoutTests/fast/replaced/maxheight-percent-expected.png and b/LayoutTests/fast/replaced/maxheight-percent-expected.png differ
index 70b841b8284a42fd384b29a2d370859cb8f817a1..e12670e97830d6b868bf8807f81b233e4489229d 100644 (file)
@@ -1 +1 @@
-6b2c40b5dd38ce422b86268b19e35043
\ No newline at end of file
+6ecf29cae56192013031cb776b08f579
\ No newline at end of file
index 79ea964e8f15835db90bcab5ad1352f9e12157a4..343d838c2b80fc2845e9dc3dc6403de689bc9d0e 100644 (file)
Binary files a/LayoutTests/fast/replaced/maxheight-pxs-expected.png and b/LayoutTests/fast/replaced/maxheight-pxs-expected.png differ
index 6dbd7a3600e91c71c237d9316017efa2f2b94222..12e2d5c74062e44c33690cbaac60e2c66c257961 100644 (file)
@@ -1 +1 @@
-fc3810de6a4400109dafc8bb723d098e
\ No newline at end of file
+0779ed369327a0f5e5550a9c340aae28
\ No newline at end of file
index 12cf9e02e4fb28ff17b720b2887fa23928654d8d..53ef76684173fdefdf9e1a7ac68b99681083f7c5 100644 (file)
Binary files a/LayoutTests/fast/replaced/maxwidth-percent-expected.png and b/LayoutTests/fast/replaced/maxwidth-percent-expected.png differ
index 70b841b8284a42fd384b29a2d370859cb8f817a1..e12670e97830d6b868bf8807f81b233e4489229d 100644 (file)
@@ -1 +1 @@
-6b2c40b5dd38ce422b86268b19e35043
\ No newline at end of file
+6ecf29cae56192013031cb776b08f579
\ No newline at end of file
index 79ea964e8f15835db90bcab5ad1352f9e12157a4..343d838c2b80fc2845e9dc3dc6403de689bc9d0e 100644 (file)
Binary files a/LayoutTests/fast/replaced/maxwidth-pxs-expected.png and b/LayoutTests/fast/replaced/maxwidth-pxs-expected.png differ
index 1ca51f982a5da742be1ead858eacf2fa61903176..f6541ec3d92622e640208d33d1fc230a5b3a4df8 100644 (file)
@@ -1 +1 @@
-1397b38865323fa1099a118a4cb60633
\ No newline at end of file
+b7325356c587c6068c55dcaeb7dbc739
\ No newline at end of file
index d5110b4938c1fe98ef0b55760b947ab73f89579f..e04e599becdfd5683a09482447d4facfdc9dca96 100644 (file)
Binary files a/LayoutTests/fast/text/atsui-spacing-features-expected.png and b/LayoutTests/fast/text/atsui-spacing-features-expected.png differ
index 01e348c7e6a1b0f7de88fef310bd6098c494591d..633ddf5463f2e58196c4ea00778816a5fa24159a 100644 (file)
@@ -1 +1 @@
-b38d628c0967fc2ad757f654473545ae
\ No newline at end of file
+b31e158b3f3dc914d8419d72bfa72c67
\ No newline at end of file
index 75481d6dc79ef5e7ad1d46dc5fc036da9c63238c..4f338d6e562940a5080f9428fe0d19c6755950ca 100644 (file)
Binary files a/LayoutTests/fast/text/in-rendered-text-rtl-expected.png and b/LayoutTests/fast/text/in-rendered-text-rtl-expected.png differ
index aa5cc8f5b5036fcc365a4710fbd25d2019d8e3cc..6942cb1a848c191deb4c07e81a28e8b2016549f3 100644 (file)
@@ -1 +1 @@
-92ef8f52824edc9d1d6ccc1b81817a20
\ No newline at end of file
+0462b59e567f46ac037ae1f88b1dda3d
\ No newline at end of file
index 67883f76d40183901366d902917b753da62cf4e8..1d221f57cfbc30969d7bdf6b39f617e9436574cd 100644 (file)
Binary files a/LayoutTests/fast/text/international/bidi-AN-after-L-expected.png and b/LayoutTests/fast/text/international/bidi-AN-after-L-expected.png differ
index 410cb2b06f0d2fdab4b60572c69fa6c8506a0623..365ea7748148217a9c44fd8e36441a9dcffed180 100644 (file)
@@ -1 +1 @@
-f1f4be3e44cccfbfa35fe78073d0db77
\ No newline at end of file
+e1bbfb860ab48cc97b428cc5e7d1a200
\ No newline at end of file
index 521dce1f8da5ce6bf78b59c6e3883004a9ba1248..0ce88eaa342a0909770ff95b4e000f67ae328f9f 100644 (file)
Binary files a/LayoutTests/fast/text/international/bidi-L2-run-reordering-expected.png and b/LayoutTests/fast/text/international/bidi-L2-run-reordering-expected.png differ
index 91d2dea82f7442c6ecc194e74a3b8cca30f78822..3a39be8e387ad805b6a9216408e93bab371287f7 100644 (file)
@@ -1 +1 @@
-f8dee5fadac8ebe2e914fdafb26a58cb
\ No newline at end of file
+a2eb059d472068d8eac65c316e312c66
\ No newline at end of file
index ca2e4b63aaa66d1bab8fde9cbfef2636b3be766d..5d12c4cf875edd580dda6a9f86744097e5693903 100644 (file)
Binary files a/LayoutTests/fast/text/international/bidi-LDB-2-CSS-expected.png and b/LayoutTests/fast/text/international/bidi-LDB-2-CSS-expected.png differ
index 98913a2020ae63b10e672e56f287a7315290facf..7b6fdcb3c1a9645ccf2a9ee9e8d5cb6841d2552b 100644 (file)
@@ -1 +1 @@
-d1d1db4df14d6f35cb65dcdfe256c0b0
\ No newline at end of file
+860cd8a971530253a306c972a610a688
\ No newline at end of file
index 56c1ef8f65fc7e65ddfe0a22a18f298c62520477..9ca037dacdd8ed738d3864bc16e6d49d2fc32466 100644 (file)
Binary files a/LayoutTests/fast/text/international/bidi-LDB-2-HTML-expected.png and b/LayoutTests/fast/text/international/bidi-LDB-2-HTML-expected.png differ
index 332b0b742a03a46a13ecb84ead78e84bac262b58..500117781c255f77faabe409927ebecb5124b531 100644 (file)
@@ -1 +1 @@
-ad58dce8300cdc1753667eb3371dfb61
\ No newline at end of file
+d1eec147523220bc76f5adce8e5d8530
\ No newline at end of file
index 5e4ad9e4632c9f15f4dcdf668b6878584f5e9c9a..343e28da8da52e69faf520ecc148c72d13a9c378 100644 (file)
Binary files a/LayoutTests/fast/text/international/bidi-LDB-2-formatting-characters-expected.png and b/LayoutTests/fast/text/international/bidi-LDB-2-formatting-characters-expected.png differ
index 9e32036e7f20b2b721584f18b6ff575f2f1a2c85..70e0651486235775e28b8b0559f76bdd7d2a06a0 100644 (file)
@@ -1 +1 @@
-f4f772c30e0575b5cc9a88802c967fd5
\ No newline at end of file
+117d287a4ccc0388c515e3851039fdaf
\ No newline at end of file
index 2bc871ae03a34be352d965df58ffc227fd44d216..faa49b846d050e0d1efad51aa4403c47e8218e17 100644 (file)
Binary files a/LayoutTests/fast/text/international/bidi-european-terminators-expected.png and b/LayoutTests/fast/text/international/bidi-european-terminators-expected.png differ
index 428335c98b7578ea3621c8a4b1b2bccd5045a56d..06a3fc4704473d526750b47e2df6f4140af17552 100644 (file)
@@ -1 +1 @@
-b2adb2a1b26314f57c602f3467b5e421
\ No newline at end of file
+e3120f58d03270a1d12e32793399ae67
\ No newline at end of file
index cefa51abf2d995387912846ae126735355821df8..f3026c0d9982fe5388e40177ea69f4372f3e45f9 100644 (file)
Binary files a/LayoutTests/fast/text/international/bidi-explicit-embedding-expected.png and b/LayoutTests/fast/text/international/bidi-explicit-embedding-expected.png differ
index 3cfe18799f030a9a0d72a3a735f5cae20526d4ab..e0db4a82282a115ff80b3c3a61ced7b3bc8a5dc7 100644 (file)
@@ -1 +1 @@
-92462bbf8ce7742c8f3bf3f6bdbcd0c3
\ No newline at end of file
+f64ed12f9ad3ea420266c8e6eb722e04
\ No newline at end of file
index 117216a44520f58b7dc82b58a4569829c9022f08..a7575920a015a82832cf0269a2b8c221bae12b5f 100644 (file)
Binary files a/LayoutTests/fast/text/international/bidi-fallback-font-weight-expected.png and b/LayoutTests/fast/text/international/bidi-fallback-font-weight-expected.png differ
index fa5654ee088f812672e7ea66094942fac473c306..7ad5ed593e658f979bdb6845aaa978163f5877ce 100644 (file)
@@ -1 +1 @@
-f90a8036c18922e81d5ea516799ecf8e
\ No newline at end of file
+7dba6bea8fff3c972f45d902a57c8e10
\ No newline at end of file
index dbcf5e7eba5394ea79df70d032e33c61f705e072..984d55f9f5c3de423c02495410bc86876f1defb2 100644 (file)
Binary files a/LayoutTests/fast/text/international/bidi-ignored-for-first-child-inline-expected.png and b/LayoutTests/fast/text/international/bidi-ignored-for-first-child-inline-expected.png differ
index b6a2050ccbb8cfd0896d77a90d0ad1a2a0078ef9..dba8f646538b18f8ad930445c2c6c573c309ba0d 100644 (file)
@@ -1 +1 @@
-daefd84576464a5e288ab49d2c084eb4
\ No newline at end of file
+c8e8c9f465db578766fd842616a1b6ec
\ No newline at end of file
index c9cb5223d47c097a08647e75903676daf384e3f6..ab76d242bcf46c5a1511418a08d25d4725af98fa 100644 (file)
Binary files a/LayoutTests/fast/text/international/bidi-innertext-expected.png and b/LayoutTests/fast/text/international/bidi-innertext-expected.png differ
index e6c4cdbb3cfd30ba14854697546c3eb27fbbae70..dbe6e2c226f7eb2323c8b563c1223e18ddea88f8 100644 (file)
@@ -1 +1 @@
-5c25b1d0fa42e1db7dabcbc3ac448e71
\ No newline at end of file
+7defa9ecf4810ca02eec1c4a91f8d4ad
\ No newline at end of file
index 176b6276eb540d4bd698b683e7cc4525846d8b70..daf20bc15c665d55e4b536501da5cb8f4965e671 100644 (file)
Binary files a/LayoutTests/fast/text/international/bidi-layout-across-linebreak-expected.png and b/LayoutTests/fast/text/international/bidi-layout-across-linebreak-expected.png differ
index 94b033bb4de20644b3ec6a2b9d32778862ca1495..09221430fcf0efd494e3015d1eff3b5d773184f1 100644 (file)
@@ -1 +1 @@
-c3f64457bc7f308e04e66b997bb483b0
\ No newline at end of file
+9408b489474e6a47c9d5288e4ce62bca
\ No newline at end of file
index ef7d273966ce03267c01bcf6adda0988e46e3689..ad8431c0ca513972479ca1072f52da0f0231fa63 100644 (file)
Binary files a/LayoutTests/fast/text/international/bidi-override-expected.png and b/LayoutTests/fast/text/international/bidi-override-expected.png differ
index 523d69adb6454d779194ac0c35b69c9ded04877b..23f7b6cf5dd4d59f1cf965622a72b69a116c1a9c 100644 (file)
@@ -1 +1 @@
-d32a34f9d74da098f828f6328401f3b8
\ No newline at end of file
+e35706ada8bb50e13024726b08d859b1
\ No newline at end of file
index d821e4cac79ac9957c11026b3ce02814dc40c01b..b66c7b2df2674e90c1a7de057d21151e8d4f9fa2 100644 (file)
Binary files a/LayoutTests/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png and b/LayoutTests/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png differ
index 3e6bfb8136e172f4211122dccf1e0b6e7b332504..450d7201cf8d2513625e38f286bc9651167cf652 100644 (file)
@@ -1 +1 @@
-434da7f2bf541af38ec728dd6919a742
\ No newline at end of file
+e09162689745e7792648d33ec2b3225d
\ No newline at end of file
index d4775dd39e7476d6e68a2b082b49b07b6da08f5f..90b4444459d17d270c566fc9eadc24c7a48c807e 100644 (file)
Binary files a/LayoutTests/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png and b/LayoutTests/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png differ
index 8d2f2376825b845858f922d80f721ececfbbbe8d..d0d54dad94029dde77116b27d08708c4a3ba76a2 100644 (file)
@@ -1 +1 @@
-8a6c7fec2c8a3ca1470bad31006cca75
\ No newline at end of file
+efc6dd5325aa09d2410c0c7a473e2656
\ No newline at end of file
index 35363abb8a579b0c0c76f076a89e4cce0a8a3561..70d35413a3a1e2318523ea7cc689bccf98a8acd9 100644 (file)
Binary files a/LayoutTests/svg/W3C-SVG-1.1/filters-color-01-b-expected.png and b/LayoutTests/svg/W3C-SVG-1.1/filters-color-01-b-expected.png differ
index c64efd887547a8228c732c157dfb0fa236c36eb6..6ac6a8f9c024360170a2694a1e788db3c57f7c2e 100644 (file)
@@ -1 +1 @@
-f398fac256621b8eab8a8e22a81a188b
\ No newline at end of file
+77915218b695bec492560bd30b05fef9
\ No newline at end of file
index 255b6c4a1861224812785390ed6c8c886417c533..48a1d52ad0817e5d3f20b33b445e063c4958e6a6 100644 (file)
Binary files a/LayoutTests/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png and b/LayoutTests/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png differ
index 3976dc4816a9c25b88103e1d1bef8f05a9d045c8..00b0ea6b1ece25981553579b18059963b03b6572 100644 (file)
@@ -1 +1 @@
-bf79998774a172ea008667b7f4954d74
\ No newline at end of file
+e58d793cc4509a341e33cfd9e0a78b81
\ No newline at end of file
index c6c7aa887a986d1877b728cedcd87187afe92730..3c5fa7e5ee07dba6dec9bcb434fc8d5bbeda524f 100644 (file)
Binary files a/LayoutTests/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png and b/LayoutTests/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png differ
index 6560ba6e00845f1815ea3b52f5ee1650bcca9990..c461be8d4f5a559c6bd2151e4e28a87ad094c977 100644 (file)
@@ -1 +1 @@
-2050fe10c8bc90ed2efc28575e97599b
\ No newline at end of file
+e3718b85fd6a702a648bf536234a49c3
\ No newline at end of file
index 9537e525986e1cee453a3317f84226b2dbeaff7e..5d7138d56ee81536497be8f89c0718a0da2c1eb4 100644 (file)
Binary files a/LayoutTests/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png and b/LayoutTests/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png differ
index f141e862b206aeda2fd216dedbb3a27ec8ee57f0..f9ed3400f5358e85262b7c9431a5a1c3d98ddb88 100644 (file)
@@ -1 +1 @@
-2805e383fad9fb6a6b725ad0f098d9bb
\ No newline at end of file
+5ddd5f9151ce9cf8da3ce9c2fa22fcae
\ No newline at end of file
index e9efbb7a035619a993848197f5fe2e49b2217a51..edbd707a8906d2a06bcff18b1ce90a6f16bc3fa4 100644 (file)
Binary files a/LayoutTests/svg/W3C-SVG-1.1/filters-example-01-b-expected.png and b/LayoutTests/svg/W3C-SVG-1.1/filters-example-01-b-expected.png differ
index cc0bca69bb19a8bff4489ab60dedc53d12e65693..876fed8cf710c9665291af18573a5e9f8e84c9ad 100644 (file)
@@ -1 +1 @@
-0b12e9790a8e86d754e15943e41539ef
\ No newline at end of file
+ea48d4e67eb50813fda31e6e2bc53e92
\ No newline at end of file
index 356a0fb30fe4f634ebf39acb812f579a19b527b1..30c16ca71d297e13d0a808c0c06dd08375e5deb5 100644 (file)
Binary files a/LayoutTests/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png and b/LayoutTests/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png differ
index e842ee54dc99e449f579afd7bef71626a36c4737..a590edde6fadae27751c254cdce760c959d3453e 100644 (file)
@@ -1 +1 @@
-1541f776c80827ce9f246d933718dbd6
\ No newline at end of file
+160306f79a3f3b63dd12558ae5e8d7bb
\ No newline at end of file
index 875e9728f2eb3692e35c1b311380304854b8da1b..3ec71c6a4d917c48cd1585e75e0f56b27e9bd929 100644 (file)
Binary files a/LayoutTests/svg/W3C-SVG-1.1/filters-image-01-b-expected.png and b/LayoutTests/svg/W3C-SVG-1.1/filters-image-01-b-expected.png differ
index 87cfb1fe26ecb9c2271900c7f0bdf3abe764d7ab..f5e7c093fd039c25ebaadb0239e9dddb2594af09 100644 (file)
@@ -1 +1 @@
-5798eed21c31573bcd1bad9e33eda10a
\ No newline at end of file
+080d55551ac2be5e5a83ce796e03395f
\ No newline at end of file
index f00859cb517947981c6c56a9242e53117fde1221..9dcd03c91db62bac23d8ec8ff1734b7d1d374c93 100644 (file)
Binary files a/LayoutTests/svg/W3C-SVG-1.1/filters-light-01-f-expected.png and b/LayoutTests/svg/W3C-SVG-1.1/filters-light-01-f-expected.png differ
index 41da262d40985d78e45ef5ad4cbcae13cfb941cb..8194b22fcee71af7466eadfa0d35d79d6ee5a587 100644 (file)
@@ -1 +1 @@
-9a46cbfe0ee5b02539acf679f8028dd9
\ No newline at end of file
+d8407899ca82f38202edbb981e5bcfa1
\ No newline at end of file
index 0e6df065b676c25fc8944ee52ba5d6164638f4b1..bbcd077ea7d2b3acd79851bd9c0421d733ff4170 100644 (file)
Binary files a/LayoutTests/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png and b/LayoutTests/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png differ
index 5fc3c0122f011a704f66b42a7104b951712fd5ad..fd87332d1febc3246bbec032ae0c3cf648b55285 100644 (file)
@@ -1 +1 @@
-ac166d1de464a157b324587ed2d161b7
\ No newline at end of file
+ca449b5ff04fa1a455264877e6f3c5e1
\ No newline at end of file
index f0d52a079ff36bfb5ba2f25a16dcf64174525183..980bc3cbf021c2936ca8c1731b1c789890191dbb 100644 (file)
Binary files a/LayoutTests/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png and b/LayoutTests/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png differ
index e3119c650d7794a54398e5014dc0526016376d47..a87a18c0d5c0654a9126d7aa53dcb5d4b27356fd 100644 (file)
@@ -1 +1 @@
-3496bf1e9ad67e32f03c065e6888958a
\ No newline at end of file
+7105fd856be4c1be2936ef496d596fc3
\ No newline at end of file
index b75ef8d00ef7b78b16fa1a729a2c76fe177d5b14..f3c5a10e921a79ff39772a5f348ef07acd359146 100644 (file)
Binary files a/LayoutTests/svg/custom/feDisplacementMap-01-expected.png and b/LayoutTests/svg/custom/feDisplacementMap-01-expected.png differ
index 6e5eea45d5ccb47ba33ec1731f89932db3b84307..736384124a3002d4f089de3cb33b8bcfc8632d28 100644 (file)
@@ -1 +1 @@
-5fa12497e04507ebb20ab8c1059b7cbd
\ No newline at end of file
+778803df0a824ed8f2c7dfa07c56832e
\ No newline at end of file
index b2a24c6898a798fe80d031d3d45bc7e3d133b2d0..3db2634a02cf66b801aa1b94cb06d666a42e429f 100644 (file)
Binary files a/LayoutTests/svg/custom/filter-source-alpha-expected.png and b/LayoutTests/svg/custom/filter-source-alpha-expected.png differ
index 2faea18f36d9a0af906654f014596721d9149f63..d3f9673b2856626b23ea14dec8924cce5705fac5 100644 (file)
@@ -1 +1 @@
-028ccc4e8bbe077b22d900682dbef566
\ No newline at end of file
+24f4ba5a9a930beca8c1d1ea49356005
\ No newline at end of file
index bd36e48f005ec70d0e988db29039a2a47ca474ec..e6f3afd53af6f11190473c67b5989e4236995bc6 100644 (file)
Binary files a/LayoutTests/svg/custom/image-with-transform-clip-filter-expected.png and b/LayoutTests/svg/custom/image-with-transform-clip-filter-expected.png differ
index 3a4f1f7086de2672c5ab937ddac1269be537e933..736384124a3002d4f089de3cb33b8bcfc8632d28 100644 (file)
@@ -1 +1 @@
-16310588467cfc20d551635abc59b784
\ No newline at end of file
+778803df0a824ed8f2c7dfa07c56832e
\ No newline at end of file
index da9caf8aaf79aafc1d04556878de99ab8b09583b..b3cd71d1b08d7780ab18c78ffcb0ff1e1663ac72 100644 (file)
@@ -1 +1 @@
-0cfed38747f991e6cb364c3d920e92d7
\ No newline at end of file
+ca758134f971941a127e522830bc6856
\ No newline at end of file
index 629ee1e4e9f2d2bd2d6577afd07e1bb70869a004..3581d5f76752829ffb1e70854934b3341499f2c6 100644 (file)
Binary files a/LayoutTests/svg/custom/text-filter-expected.png and b/LayoutTests/svg/custom/text-filter-expected.png differ
index 280da4c103f05fa7b76aeb49332cf524b7a10439..2197546dbbbfe2609633e0830b03180f751e1ec4 100644 (file)
@@ -1 +1 @@
-bc8e1944ac004703b3836afc81dcaf71
\ No newline at end of file
+16b14a694efdd66b070c6e52415f0f0c
\ No newline at end of file
index cf2811de847e1cdafc3a03ba350de850be8aa68f..4b9a0b812d584b764dc4df88d97bfc490d9686eb 100644 (file)
Binary files a/LayoutTests/svg/custom/text-image-opacity-expected.png and b/LayoutTests/svg/custom/text-image-opacity-expected.png differ
index 7daf04b0207292b3a7910056645d14668439ceb9..f22188cdad26772e15b6cf51df1119526516d09c 100644 (file)
@@ -1,3 +1,20 @@
+2006-04-10  Mitz Pettel  <opendarwin.org@mitzpettel.com>
+
+        Reviewed by Darin.
+
+        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8100
+          REGRESSION (NativeTextField): Right-aligned and RTL text jitters in new text fields
+
+        * WebCoreSupport/WebTextRenderer.m:
+        (overrideLayoutOperation): For RTL runs, apply the word-rounding on the left.
+        (CG_floatWidthForRun): For RTL runs, apply the last character's rounding
+        on the left by adjusting the start position.
+        (initializeWidthIterator): Added finalRoundingWidth field to WidthIterator.
+        (advanceWidthIterator): For RTL runs, apply rounding on the left of the character,
+        by increasing the width of the next character (which is the character to the left). For
+        the last character, keep the rounding width in the iterator's finalRoundingWidth, to be used by
+        CG_floatWidthForRun().
+
 2006-04-08  John Sullivan  <sullivan@apple.com>
 
         Reviewed by Adele Peterson.
index 80818a3af1896e1a90be4b5002492fd5fd899d70..3741b8398c2ef2a8f128b41d882ccf033c92b17d 100644 (file)
@@ -107,6 +107,7 @@ typedef struct WidthIterator {
     float widthToStart;
     float padding;
     float padPerSpace;
+    float finalRoundingWidth;
 } WidthIterator;
 
 typedef struct ATSULayoutParameters
@@ -256,6 +257,7 @@ static OSStatus overrideLayoutOperation(ATSULayoutOperationSelector iCurrentOper
         float padding = style->padding;
         // In the CoreGraphics code path, the rounding hack is applied in logical order.
         // Here it is applied in visual left-to-right order, which may be better.
+        ItemCount lastRoundingChar = 0;
         ItemCount i;
         for (i = 1; i < count; i++) {
             bool isLastChar = i == count - 1;
@@ -306,11 +308,22 @@ static OSStatus overrideLayoutOperation(ATSULayoutOperationSelector iCurrentOper
             if (isRoundingHackCharacter(ch))
                 width = ceilf(width);
             lastAdjustedPos = lastAdjustedPos + width;
-            if (isRoundingHackCharacter(nextCh))
-                if (!isLastChar
-                        || style->applyRunRounding
-                        || (run->to < (int)run->length && isRoundingHackCharacter(characters[run->to - run->from])))
+            if (isRoundingHackCharacter(nextCh)
+                && (!isLastChar
+                    || style->applyRunRounding
+                    || (run->to < (int)run->length && isRoundingHackCharacter(characters[run->to - run->from])))) {
+                if (!style->rtl)
                     lastAdjustedPos = ceilf(lastAdjustedPos);
+                else {
+                    float roundingWidth = ceilf(lastAdjustedPos) - lastAdjustedPos;
+                    Fixed rw = FloatToFixed(roundingWidth);
+                    ItemCount j;
+                    for (j = lastRoundingChar; j < i; j++)
+                        layoutRecords[j].realPos += rw;
+                    lastRoundingChar = i;
+                    lastAdjustedPos += roundingWidth;
+                }
+            }
             if (syntheticBoldPass) {
                 if (syntheticBoldOffset)
                     layoutRecords[i-1].realPos += syntheticBoldOffset;
@@ -1047,8 +1060,9 @@ static float CG_floatWidthForRun(WebTextRenderer *renderer, const WebCoreTextRun
         if (!style->rtl)
             *startPosition = it.widthToStart;
         else {
+            float finalRoundingWidth = it.finalRoundingWidth;
             advanceWidthIterator(&it, run->length, 0, 0, 0);
-            *startPosition = it.runWidthSoFar - runWidth;
+            *startPosition = it.runWidthSoFar - runWidth + finalRoundingWidth;
         }
     }
     if (numGlyphsResult)
@@ -1752,6 +1766,7 @@ static void initializeWidthIterator(WidthIterator *iterator, WebTextRenderer *re
     iterator->style = style;
     iterator->currentCharacter = run->from;
     iterator->runWidthSoFar = 0;
+    iterator->finalRoundingWidth = 0;
 
     // If the padding is non-zero, count the number of spaces in the run
     // and divide that by the padding for per space addition.
@@ -1815,10 +1830,12 @@ static unsigned advanceWidthIterator(WidthIterator *iterator, unsigned offset, f
     const UniChar *cp = &run->characters[currentCharacter];
 
     const WebCoreTextStyle *style = iterator->style;
-    bool needCharTransform = style->rtl | style->smallCaps;
+    bool rtl = style->rtl;
+    bool needCharTransform = rtl | style->smallCaps;
     bool hasExtraSpacing = style->letterSpacing | style->wordSpacing | style->padding;
 
     float runWidthSoFar = iterator->runWidthSoFar;
+    float lastRoundingWidth = iterator->finalRoundingWidth;
 
     while (currentCharacter < offset) {
         UChar32 c = *cp;
@@ -1854,7 +1871,7 @@ static unsigned advanceWidthIterator(WidthIterator *iterator, unsigned offset, f
         WebTextRenderer *renderer = iterator->renderer;
 
         if (needCharTransform) {
-            if (style->rtl)
+            if (rtl)
                 c = u_charMirror(c);
 
             // If small-caps, convert lowercase to upper.
@@ -1944,6 +1961,8 @@ static unsigned advanceWidthIterator(WidthIterator *iterator, unsigned offset, f
         // We adjust the width of the last character of a "word" to ensure an integer width.
         // If we move KHTML to floats we can remove this (and related) hacks.
 
+        float oldWidth = width;
+
         // Force characters that are used to determine word boundaries for the rounding hack
         // to be integer width, so following words will start on an integer boundary.
         if (style->applyWordRounding && isRoundingHackCharacter(c))
@@ -1965,16 +1984,18 @@ static unsigned advanceWidthIterator(WidthIterator *iterator, unsigned offset, f
         } else {
             ASSERT(renderersUsed);
             ASSERT(glyphsUsed);
-            *widths++ = width;
+            *widths++ = (rtl ? oldWidth + lastRoundingWidth : width);
             *renderersUsed++ = renderer;
             *glyphsUsed++ = glyph;
         }
 
+        lastRoundingWidth = width - oldWidth;
         ++numGlyphs;
     }
 
     iterator->currentCharacter = currentCharacter;
     iterator->runWidthSoFar = runWidthSoFar;
+    iterator->finalRoundingWidth = lastRoundingWidth;
 
     return numGlyphs;
 }