AX: audio/video playback control timers (elapsed and remaining) should be exposed...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 21 Jun 2013 20:21:07 +0000 (20:21 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 21 Jun 2013 20:21:07 +0000 (20:21 +0000)
https://bugs.webkit.org/show_bug.cgi?id=117883

Patch by James Craig <james@cookiecrook.com> on 2013-06-21
Reviewed by Chris Fleizach.

Some of the media controls were returning the wrong role. Updated existing test coverage.

Source/WebCore:

* accessibility/AccessibilityMediaControls.h:
(WebCore::AccessibilityMediaTimeDisplay::roleValue):

LayoutTests:

* accessibility/media-element.html:
* platform/mac/accessibility/media-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/accessibility/media-element.html
LayoutTests/platform/mac/accessibility/media-element-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/accessibility/AccessibilityMediaControls.h

index a3ba761..7316c69 100644 (file)
@@ -1,3 +1,15 @@
+2013-06-21  James Craig  <james@cookiecrook.com>
+
+        AX: audio/video playback control timers (elapsed and remaining) should be exposed as ApplicationTimerRole
+        https://bugs.webkit.org/show_bug.cgi?id=117883
+
+        Reviewed by Chris Fleizach.
+
+        Some of the media controls were returning the wrong role. Updated existing test coverage.
+
+        * accessibility/media-element.html:
+        * platform/mac/accessibility/media-element-expected.txt:
+
 2013-06-20  Brent Fulgham  <bfulgham@apple.com>
 
         [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs.
index a0df2fe..8b42636 100644 (file)
@@ -20,6 +20,7 @@
             {
                 debug(indent(indentLevel) + "description: " + axObject.description); 
                 debug(indent(indentLevel) + "role: " + axObject.role); 
+                if (axObject.subrole != 'AXSubrole: ') debug(indent(indentLevel) + "subrole: " + axObject.subrole); 
                 debug("<br>");
             }
 
index 8c0653b..ad585d2 100644 (file)
@@ -17,11 +17,21 @@ State at 'canplaythrough' event:
 
 
         description: AXDescription: elapsed time
-        role: AXRole: AXStaticText
+        role: AXRole: AXGroup
+        subrole: AXSubrole: AXApplicationTimer
+
+
+            description: AXDescription: 
+            role: AXRole: AXGroup
+
+
+                description: AXDescription: 
+                role: AXRole: AXStaticText
 
 
         description: AXDescription: 
         role: AXRole: AXSlider
+        subrole: AXSubrole: AXTimeline
 
 
             description: AXDescription: 
@@ -29,7 +39,16 @@ State at 'canplaythrough' event:
 
 
         description: AXDescription: remaining time
-        role: AXRole: AXStaticText
+        role: AXRole: AXGroup
+        subrole: AXSubrole: AXApplicationTimer
+
+
+            description: AXDescription: 
+            role: AXRole: AXGroup
+
+
+                description: AXDescription: 
+                role: AXRole: AXStaticText
 
 
         description: AXDescription: enter fullscreen
index a5fd729..2a685be 100644 (file)
@@ -1,3 +1,15 @@
+2013-06-21  James Craig  <james@cookiecrook.com>
+
+        AX: audio/video playback control timers (elapsed and remaining) should be exposed as ApplicationTimerRole
+        https://bugs.webkit.org/show_bug.cgi?id=117883
+
+        Reviewed by Chris Fleizach.
+
+        Some of the media controls were returning the wrong role. Updated existing test coverage.
+
+        * accessibility/AccessibilityMediaControls.h:
+        (WebCore::AccessibilityMediaTimeDisplay::roleValue):
+
 2013-06-21  Alex Christensen  <achristensen@apple.com>
 
         Added glext.h from http://www.opengl.org/registry/oldspecs/glext.h for Windows
index 628d70e..337ec5c 100644 (file)
@@ -100,7 +100,7 @@ public:
     static PassRefPtr<AccessibilityObject> create(RenderObject*);
     virtual ~AccessibilityMediaTimeDisplay() { }
 
-    virtual AccessibilityRole roleValue() const { return StaticTextRole; }
+    virtual AccessibilityRole roleValue() const { return ApplicationTimerRole; }
 
     virtual String stringValue() const;
     virtual String accessibilityDescription() const;