Reviewed by Maciej.
authorggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 Nov 2006 01:35:00 +0000 (01:35 +0000)
committerggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 1 Nov 2006 01:35:00 +0000 (01:35 +0000)
        Fixed crash resulting from Darin's last patch to remove BrowserExtension.

        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::createWindow):
        * manual-tests/window-open-features-parsing.html: Updated for clarity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/loader/mac/FrameLoaderMac.mm
WebCore/manual-tests/window-open-features-parsing.html

index 840177d06d7e1a502f43e186aa7a8fc4031ab6fa..e2cddaa66e31d8dd1f9b1ccc6b4ab0647912226e 100644 (file)
@@ -1,3 +1,13 @@
+2006-10-31  Geoffrey Garen  <ggaren@apple.com>
+
+        Reviewed by Maciej.
+        
+        Fixed crash resulting from Darin's last patch to remove BrowserExtension.
+
+        * loader/mac/FrameLoaderMac.mm:
+        (WebCore::FrameLoader::createWindow):
+        * manual-tests/window-open-features-parsing.html: Updated for clarity.
+
 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
 
         Reviewed by Alice.
index ebe3232e6559c95725114d258ea2799a521a0c9a..f384ef1d27182fcf39a1e94b2fe412a455dcc89c 100644 (file)
@@ -414,7 +414,10 @@ Frame* FrameLoader::createWindow(const FrameLoadRequest& request, const WindowFe
     // the window, so adjust for the difference between the window size and the view size.
 
     FloatRect windowRect = page->windowRect();
-    IntSize frameViewSize = frame->view()->size();
+    
+    // FIXME: We'd like to get frameViewSize from the frame's view, but that doesn't
+    // get created until the frame loads its document.
+    IntSize frameViewSize = IntSize([[pageBridge outerView] frame].size);
     if (features.xSet)
         windowRect.setX(features.x);
     if (features.ySet)
index cd686abf384407aac34d704f748cc53d1d75fe7f..f75f2a31215044c6747b8aa8311a8c7cac27ac0c 100644 (file)
@@ -27,7 +27,10 @@ function test() {
 </ul>
 <a href="" onclick="test(); return false;">Click to test</a>
 <hr>
-<p>The link below should open a window whose dimensions and positioning match
-what you would get from file->New Window.</p>
+<p>The link below should open a window with the following attributes:</p>
+<ul>
+<li>A WebView whose size matches what you would get from file->New Window</li>
+<li>A window whose positioning matches what you would get from file->New Window</li>
+</ul>
 <a href="" onclick='window.open("", "", "status,resizable");'>Click to test</a>
 </body></html>