- Fix for bug 8833. Removed inline keyword from functions declared

        in .mm and .cpp files. inline function code needs to reside in the
        header file for the linker to find the code.
        http://www.parashift.com/c++-faq-lite/inline-functions.html#faq-9.7

        Reviewed by Darin, landed by Timothy.

        * platform/Font.cpp:
        (WebCore::isSpace):
        * platform/mac/FontData.mm:
        (WebCore::widthForGlyph):
        (WebCore::isRoundingHackCharacter):
        (WebCore::glyphForCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index 0f17aa252639d70bc4ab2ca567dcd6669c7436ba..82f8638ee01e8cee900c315d22950bf9169cc912 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,19 @@
+2006-05-10  David Carson <dacarson@gmail.com>
+
+        - Fix for bug 8833. Removed inline keyword from functions declared
+        in .mm and .cpp files. inline function code needs to reside in the
+        header file for the linker to find the code. 
+        http://www.parashift.com/c++-faq-lite/inline-functions.html#faq-9.7
+
+        Reviewed by Darin, landed by Timothy.
+
+        * platform/Font.cpp:
+        (WebCore::isSpace):
+        * platform/mac/FontData.mm:
+        (WebCore::widthForGlyph):
+        (WebCore::isRoundingHackCharacter):
+        (WebCore::glyphForCharacter):
+
 2006-05-10  Mitz Pettel  <opendarwin.org@mitzpettel.com>
 
         Reviewed and landed by Anders.

diff --git a/WebCore/platform/Font.cpp b/WebCore/platform/Font.cpp
index 02b0c603641bacf6c322e17a1864d73bd40ca499..948e8fd9403ae6198174971ee155f24060435057 100644 (file)
--- a/WebCore/platform/Font.cpp
+++ b/WebCore/platform/Font.cpp
@@ -46,7 +46,7 @@ namespace WebCore {
 // According to http://www.unicode.org/Public/UNIDATA/UCD.html#Canonical_Combining_Class_Values
 #define HIRAGANA_KATAKANA_VOICING_MARKS 8
 
-inline bool isSpace(unsigned c)
+ bool isSpace(unsigned c)
 {
     return c == SPACE || c == '\t' || c == '\n' || c == NO_BREAK_SPACE;
 }
@@ -62,7 +62,7 @@ static const uint8_t isRoundingHackCharacterTable[0x100] = {
     0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
 };
 
-inline bool isRoundingHackCharacter(UChar32 c)
+ bool isRoundingHackCharacter(UChar32 c)
 {
     return (((c & ~0xFF) == 0 && isRoundingHackCharacterTable[c]));
 }

diff --git a/WebCore/platform/mac/FontData.mm b/WebCore/platform/mac/FontData.mm
index 36064256d7ce4f62cb5c9cd63c23c4d08a8eecb0..44e33a4b42784774029e3b70c64cbc1d9d666e7a 100644 (file)
--- a/WebCore/platform/mac/FontData.mm
+++ b/WebCore/platform/mac/FontData.mm
@@ -203,7 +203,7 @@ static const uint8_t isRoundingHackCharacterTable[0x100] = {
     0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
 };
 
-inline bool isRoundingHackCharacter(UChar c)
+bool isRoundingHackCharacter(UChar c)
 {
     return (((c & ~0xFF) == 0 && isRoundingHackCharacterTable[c]));
 }
@@ -247,7 +247,7 @@ void WebCoreInitializeEmptyTextGeometry(WebCoreTextGeometry *geometry)
 
 // Map utility functions
 
-inline float FontData::widthForGlyph(Glyph glyph) const
+float FontData::widthForGlyph(Glyph glyph) const
 {
     WidthMap *map;
     for (map = m_glyphToWidthMap; 1; map = map->next) {
@@ -1737,7 +1737,7 @@ static void freeGlyphMap(GlyphMap *map)
     }
 }
 
-inline Glyph FontData::glyphForCharacter(const FontData **renderer, unsigned c) const
+Glyph FontData::glyphForCharacter(const FontData **renderer, unsigned c) const
 {
     // this loop is hot, so it is written to avoid LSU stalls
     GlyphMap *map;