Perf dashboard should show relative change in values

https://bugs.webkit.org/show_bug.cgi?id=143252

Reviewed by Antti Koivisto.

When a range of values are selected, show the percentage difference between the start and the end
in addition to the absolute value difference. When a single point is selected, show the relative
difference with respect to the previous point. Use two significant figures and always show plus sign
when the difference is positive.

* public/v2/app.js: Compute and format the relative difference.
* public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
* public/v2/index.html: Show the relative difference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@182185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog
index 35b3abd26167bafcd3319dc1ab8f152edb7378e8..bf4c3a3f47498e35c5e4cfbbf95a14b3c8ec7706 100644 (file)
--- a/Websites/perf.webkit.org/ChangeLog
+++ b/Websites/perf.webkit.org/ChangeLog
@@ -1,3 +1,19 @@
+2015-03-31  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Perf dashboard should show relative change in values
+        https://bugs.webkit.org/show_bug.cgi?id=143252
+
+        Reviewed by Antti Koivisto.
+
+        When a range of values are selected, show the percentage difference between the start and the end
+        in addition to the absolute value difference. When a single point is selected, show the relative
+        difference with respect to the previous point. Use two significant figures and always show plus sign
+        when the difference is positive.
+
+        * public/v2/app.js: Compute and format the relative difference.
+        * public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
+        * public/v2/index.html: Show the relative difference.
+
 2015-03-31  Ryosuke Niwa  <rniwa@webkit.org>
 
         REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph

diff --git a/Websites/perf.webkit.org/public/v2/app.js b/Websites/perf.webkit.org/public/v2/app.js
index 0f75449cca2b5c0c1e8631f76531a49566dbfcf7..58f8288c0c8ad5b7af542fa798f11a7deb00c051 100755 (executable)
--- a/Websites/perf.webkit.org/public/v2/app.js
+++ b/Websites/perf.webkit.org/public/v2/app.js
@@ -424,7 +424,13 @@ App.Pane = Ember.Object.extend({
             label = formatter(Math.abs(diffFromTarget)) + ' until target';
 
         var valueDelta = previousPoint ? chartData.deltaFormatter(currentPoint.value - previousPoint.value) : null;
-        return {className: className, label: label, currentValue: chartData.formatter(currentPoint.value), valueDelta: valueDelta};
+        return {
+            className: className,
+            label: label,
+            currentValue: chartData.formatter(currentPoint.value),
+            valueDelta: valueDelta,
+            relativeDelta: d3.format('+.2p')((currentPoint.value - previousPoint.value) / previousPoint.value),
+        };
     },
     _relativeDifferentToLaterPointInTimeSeries: function (currentPoint, timeSeries)
     {

diff --git a/Websites/perf.webkit.org/public/v2/chart-pane.css b/Websites/perf.webkit.org/public/v2/chart-pane.css
index e6d1f8627f5cd5bb38b0e4a1bf9d4728e540a18f..8e5bf8cf9c394363cfdbd64beca8625af9f64ac5 100755 (executable)
--- a/Websites/perf.webkit.org/public/v2/chart-pane.css
+++ b/Websites/perf.webkit.org/public/v2/chart-pane.css
@@ -241,6 +241,10 @@
     border-collapse: collapse;
 }
 
+.chart-pane .commits-viewer {
+    width: 100%;
+}
+
 .chart-pane .details-table td:last-child {
     padding-right: 1px;
 }

diff --git a/Websites/perf.webkit.org/public/v2/index.html b/Websites/perf.webkit.org/public/v2/index.html
index eb32ae2d42450399a20db701c4ec5eb2e2792ee5..e6d92507bff1110fb89ebd8860d85de4b86a2784 100755 (executable)
--- a/Websites/perf.webkit.org/public/v2/index.html
+++ b/Websites/perf.webkit.org/public/v2/index.html
@@ -270,7 +270,7 @@
                     <td>
                         {{details.status.currentValue}} {{chartData.unit}}
                         {{#if details.status.valueDelta}}
-                            ({{details.status.valueDelta}} {{chartData.unit}})
+                            ({{details.status.valueDelta}} {{chartData.unit}} / {{details.status.relativeDelta}})
                         {{/if}}
                         {{#if details.status.label}}
                             <br>