2009-03-17 Ojan Vafai <ojan@chromium.org>
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Mar 2009 23:44:11 +0000 (23:44 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Mar 2009 23:44:11 +0000 (23:44 +0000)
commitffdfec253f0ea6300102a47ea6f70c95c093c244
tree7732e28c6e788f656e82187d96f0a7ed8d81ec0e
parent8a1b0dd9dc5d230574200aba2754e8ca88787be3
2009-03-17  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adele Peterson.

        Put the padding inside scrollbars on textareas.
        https://bugs.webkit.org/show_bug.cgi?id=24370

        Put the padding inside the scrollbars on textareas. This is done by moving the
        overflow from the shadowNode to the RenderTextControlMultiline. As a result,
        all of the scroll handing methods that RenderTextControl overrides can be moved
        down into RenderTextControlSingleLine since RenderTextControlMultiline can now
        just use RenderBlock's versions. This also allows RenderTextControlMultiLine to
        no longer need a custom layout method since the shadowNode can now just size
        like a regular DIV.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::styleDidChange):
        (WebCore::RenderTextControl::selection):
        (WebCore::RenderTextControl::calcHeight):
        (WebCore::RenderTextControl::hitInnerTextElement):
        * rendering/RenderTextControl.h:
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):
        (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
        * rendering/RenderTextControlMultiLine.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::styleDidChange):
        (WebCore::RenderTextControlSingleLine::autoscroll):
        (WebCore::RenderTextControlSingleLine::scrollWidth):
        (WebCore::RenderTextControlSingleLine::scrollHeight):
        (WebCore::RenderTextControlSingleLine::scrollLeft):
        (WebCore::RenderTextControlSingleLine::scrollTop):
        (WebCore::RenderTextControlSingleLine::setScrollLeft):
        (WebCore::RenderTextControlSingleLine::setScrollTop):
        (WebCore::RenderTextControlSingleLine::scroll):
        * rendering/RenderTextControlSingleLine.h:
        * rendering/TextControlInnerElements.cpp:
        (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
        (WebCore::RenderTextControlInnerBlock::positionForPoint):
        (WebCore::TextControlInnerTextElement::createRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
80 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/mac/editing/inserting/4960120-1-expected.txt
LayoutTests/platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt
LayoutTests/platform/mac/editing/pasteboard/pasting-tabs-expected.txt
LayoutTests/platform/mac/fast/block/margin-collapse/103-expected.txt
LayoutTests/platform/mac/fast/css/resize-corner-tracking-expected.txt
LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt
LayoutTests/platform/mac/fast/dynamic/008-expected.txt
LayoutTests/platform/mac/fast/forms/basic-textareas-expected.checksum
LayoutTests/platform/mac/fast/forms/basic-textareas-expected.png
LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt
LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt
LayoutTests/platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum
LayoutTests/platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png
LayoutTests/platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt
LayoutTests/platform/mac/fast/forms/negativeLineHeight-expected.txt
LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.txt
LayoutTests/platform/mac/fast/forms/textarea-align-expected.txt
LayoutTests/platform/mac/fast/forms/textarea-rows-cols-expected.txt
LayoutTests/platform/mac/fast/forms/textarea-scroll-height-expected.txt
LayoutTests/platform/mac/fast/forms/textarea-scrollbar-expected.txt
LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.txt
LayoutTests/platform/mac/fast/forms/textarea-setinnerhtml-expected.txt
LayoutTests/platform/mac/fast/forms/textarea-width-expected.txt
LayoutTests/platform/mac/fast/overflow/overflow-x-y-expected.txt
LayoutTests/platform/mac/fast/parser/comment-in-textarea-expected.txt
LayoutTests/platform/mac/fast/parser/entity-comment-in-textarea-expected.txt
LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.txt
LayoutTests/platform/mac/fast/replaced/width100percent-textarea-expected.txt
LayoutTests/platform/mac/fast/table/003-expected.txt
LayoutTests/platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt
LayoutTests/platform/mac/http/tests/navigation/anchor-basic-expected.txt
LayoutTests/platform/mac/http/tests/navigation/anchor-frames-expected.txt
LayoutTests/platform/mac/http/tests/navigation/anchor-goback-expected.txt
LayoutTests/platform/mac/http/tests/navigation/anchor-subframeload-expected.txt
LayoutTests/platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt
LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt
LayoutTests/platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt
LayoutTests/platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt
LayoutTests/platform/mac/http/tests/navigation/metaredirect-basic-expected.txt
LayoutTests/platform/mac/http/tests/navigation/metaredirect-frames-expected.txt
LayoutTests/platform/mac/http/tests/navigation/metaredirect-goback-expected.txt
LayoutTests/platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt
LayoutTests/platform/mac/http/tests/navigation/post-goback2-expected.txt
LayoutTests/platform/mac/http/tests/navigation/postredirect-goback2-expected.txt
LayoutTests/platform/mac/http/tests/navigation/redirect302-basic-expected.txt
LayoutTests/platform/mac/http/tests/navigation/redirect302-frames-expected.txt
LayoutTests/platform/mac/http/tests/navigation/redirect302-goback-expected.txt
LayoutTests/platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt
LayoutTests/platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt
LayoutTests/platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt
LayoutTests/platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt
LayoutTests/platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt
LayoutTests/platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt
LayoutTests/platform/mac/http/tests/navigation/success200-basic-expected.txt
LayoutTests/platform/mac/http/tests/navigation/success200-frames-expected.txt
LayoutTests/platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt
LayoutTests/platform/mac/http/tests/navigation/success200-goback-expected.txt
LayoutTests/platform/mac/http/tests/navigation/success200-loadsame-expected.txt
LayoutTests/platform/mac/http/tests/navigation/success200-reload-expected.txt
LayoutTests/platform/mac/http/tests/navigation/success200-subframeload-expected.txt
LayoutTests/platform/mac/http/tests/navigation/timerredirect-basic-expected.txt
LayoutTests/platform/mac/http/tests/navigation/timerredirect-frames-expected.txt
LayoutTests/platform/mac/http/tests/navigation/timerredirect-goback-expected.txt
LayoutTests/platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt
LayoutTests/platform/mac/tables/mozilla/bugs/bug194024-expected.txt
LayoutTests/platform/mac/tables/mozilla/bugs/bug30559-expected.txt
LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.txt
WebCore/ChangeLog
WebCore/css/CSSStyleSelector.cpp
WebCore/rendering/RenderTextControl.cpp
WebCore/rendering/RenderTextControl.h
WebCore/rendering/RenderTextControlMultiLine.cpp
WebCore/rendering/RenderTextControlMultiLine.h
WebCore/rendering/RenderTextControlSingleLine.cpp
WebCore/rendering/RenderTextControlSingleLine.h
WebCore/rendering/TextControlInnerElements.cpp