Reviewed by Darin
authorkocienda <kocienda@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Aug 2003 16:48:03 +0000 (16:48 +0000)
committerkocienda <kocienda@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Aug 2003 16:48:03 +0000 (16:48 +0000)
commitfe8623113f95c4b73b187a7735c51008d61ff6f3
tree3f2f1608ed28a13c7cdbd19fe1094defdd3b4c8e
parent96721012dac3036edf9ee08a85e97ff680f2a450
    Reviewed by Darin

Fix for this bug:

<rdar://problem/3375042>: Change usages of NSURL absoluteString in WebKit
to use improved variants

        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem initWithURL:title:]): Use data-as-string.
        (-[WebHistoryItem initWithURL:target:parent:title:]): Use data-as-string.
        (-[WebHistoryItem setURL:]): Use data-as-string.
        * History.subproj/WebHistoryPrivate.m:
        (-[WebHistoryPrivate addItem:]): Remove FIX_VISITED ifdef
        (-[WebHistoryPrivate removeItem:]): Ditto
        (-[WebHistoryPrivate containsURL:]): Ditto. Use data-as-string.
        (-[WebHistoryPrivate itemForURL:]): Ditto. Ditto.
        (-[WebHistoryPrivate loadFromURL:error:]): Fix log message to URL.
        (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]): Ditto.
        (-[WebHistoryPrivate saveToURL:error:]): Ditto.
        * History.subproj/WebURLsWithTitles.m:
        (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use visible-string.
        * Misc.subproj/WebIconLoader.m:
        (-[WebIconLoader connectionDidFinishLoading:]): Use data-as-string.
        * Misc.subproj/WebKitErrors.m:
        (+[NSError _webKitErrorWithDomain:code:URL:]): Added new convenience that takes
a URL instead of a URL string.
        (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):
Added new convenience that takes URLs instead of a URL stringis.
        * Misc.subproj/WebKitErrorsPrivate.h: Declared new conveniences.
        * Misc.subproj/WebNSPasteboardExtras.m:
        (-[NSPasteboard _web_writeURL:andTitle:withOwner:types:]): Use visible-string.
        * Misc.subproj/WebNSURLExtras.h:
        * Misc.subproj/WebNSURLExtras.m:
        (-[NSURL _web_originalDataAsString]): Added.
        (-[NSURL _webkit_isJavaScriptURL]): Use data-as-string.
        (-[NSURL _webkit_scriptIfJavaScriptURL]): Ditto
        (-[NSURL _webkit_isFTPDirectoryURL]): Ditto
        (-[NSURL _webkit_shouldLoadAsEmptyDocument]): Ditto. Also use _web_isEmpty.
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Use data-as-string.
        * Plugins.subproj/WebNetscapePluginDocumentView.m:
        (-[WebNetscapePluginDocumentView setDataSource:]): Use new error convenience.
        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): Ditto.
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge requestedURLString]): Use data-as-string.
        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Use new error convenience.
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate cancelledError]): Ditto.
        * WebView.subproj/WebDataProtocol.m:
        (-[WebDataProtocol startLoading]): Ditto.
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _stopLoadingInternal]): Ditto.
        (-[WebDataSource _updateIconDatabaseWithURL:]): Use data-as-string.
        (-[WebDataSource _loadIcon]): Ditto.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _createItem:]): Use data-as-string.
        (-[WebFrame _transitionToCommitted:]): Fix log message to use URL.
        (-[WebFrame _purgePageCache]): Use _web_isEmpty
        (-[WebFrame _setState:]): Fix log message to use URL.
        (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]): Use new error convenience.
        (-[WebFrame _loadItem:withLoadType:]): Fix log message to use URL.
        (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
        (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Fix log messages to use URL.
        (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): Use data-as-string.
        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _dragImageForLinkElement:]): Use visible-string.
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient interruptForPolicyChangeError]): Use new error convenience.
        * WebView.subproj/WebPreferences.m:
        (-[WebPreferences setUserStyleSheetLocation:]): Use data-as-string.
        * WebView.subproj/WebView.m:
        (-[WebView mainFrameURL]): Use data-as-string.
        (-[WebView mainFrameIcon]): Use data-as-string.
        * WebView.subproj/WebViewPrivate.m:
        (-[WebView _updateWebCoreSettingsFromPreferences:]): Use data-as-string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
27 files changed:
WebKit/ChangeLog
WebKit/History.subproj/WebHistoryItem.m
WebKit/History.subproj/WebHistoryPrivate.m
WebKit/History.subproj/WebURLsWithTitles.m
WebKit/Misc.subproj/WebIconLoader.m
WebKit/Misc.subproj/WebKitErrors.m
WebKit/Misc.subproj/WebKitErrorsPrivate.h
WebKit/Misc.subproj/WebNSPasteboardExtras.m
WebKit/Misc.subproj/WebNSURLExtras.h
WebKit/Misc.subproj/WebNSURLExtras.m
WebKit/Plugins.subproj/WebBaseNetscapePluginView.m
WebKit/Plugins.subproj/WebNetscapePluginDocumentView.m
WebKit/Plugins.subproj/WebNetscapePluginStream.m
WebKit/WebCoreSupport.subproj/WebBridge.m
WebKit/WebCoreSupport.subproj/WebSubresourceClient.m
WebKit/WebCoreSupport.subproj/WebSubresourceLoader.m
WebKit/WebView.subproj/WebBaseResourceHandleDelegate.m
WebKit/WebView.subproj/WebDataProtocol.m
WebKit/WebView.subproj/WebDataSourcePrivate.m
WebKit/WebView.subproj/WebFramePrivate.m
WebKit/WebView.subproj/WebHTMLViewPrivate.m
WebKit/WebView.subproj/WebLoader.m
WebKit/WebView.subproj/WebMainResourceClient.m
WebKit/WebView.subproj/WebMainResourceLoader.m
WebKit/WebView.subproj/WebPreferences.m
WebKit/WebView.subproj/WebView.m
WebKit/WebView.subproj/WebViewPrivate.m