LayoutTests:
authordarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 17 Apr 2006 06:50:04 +0000 (06:50 +0000)
committerdarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 17 Apr 2006 06:50:04 +0000 (06:50 +0000)
commitfca066dbf79a68a695fdee90e973f177ec66c6dd
tree901411e9d6cfecbd82e1b62d88915cb12c5bf97b
parenta412c546f909064f18a70c1e29c5d081d43363ef
LayoutTests:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8408
          Paint the highlight behind selected list markers

        * editing/selection/extend-by-word-002-expected.checksum: Updated.
        * editing/selection/extend-by-word-002-expected.png: Updated.
        * fast/lists/markers-in-selection-expected.checksum: Added.
        * fast/lists/markers-in-selection-expected.png: Added.
        * fast/lists/markers-in-selection-expected.txt: Added.
        * fast/lists/markers-in-selection.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8408
          Paint the highlight behind selected list markers

        Test: fast/lists/markers-in-selection.html

        * rendering/RenderObject.h: Added selectionColorImageOverlayAlpha constant -
        the maximum opacity of the selection color when painted over images.
        * rendering/render_list.cpp:
        (WebCore::RenderListMarker::RenderListMarker):
        (WebCore::RenderListMarker::paint): Paint the selection highlight
        if selected: over the marker for image markers, under the marker for all other
        markers.
        (WebCore::RenderListMarker::setSelectionState): Added.
        (WebCore::RenderListMarker::selectionRect): Added.
        (WebCore::RenderListMarker::selectionColor): Added. Ensures that the selection
        color is transparent for image markers.
        * rendering/render_list.h:
        (WebCore::RenderListMarker::selectionState):
        (WebCore::RenderListMarker::canBeSelectionLeaf):
        * rendering/render_replaced.cpp
        (WebCore::RenderReplaced::selectionColor): Changed to use the selectionColorImageOverlayAlpha
        constant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
12 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/selection/extend-by-word-002-expected.checksum
LayoutTests/editing/selection/extend-by-word-002-expected.png
LayoutTests/fast/lists/markers-in-selection-expected.checksum [new file with mode: 0644]
LayoutTests/fast/lists/markers-in-selection-expected.png [new file with mode: 0644]
LayoutTests/fast/lists/markers-in-selection-expected.txt [new file with mode: 0644]
LayoutTests/fast/lists/markers-in-selection.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/rendering/RenderObject.h
WebCore/rendering/render_list.cpp
WebCore/rendering/render_list.h
WebCore/rendering/render_replaced.cpp