LayoutTests:
authoradele <adele@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Nov 2006 21:37:46 +0000 (21:37 +0000)
committeradele <adele@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Nov 2006 21:37:46 +0000 (21:37 +0000)
commitf65b5deffa4548266a6e4fbe190cbb63cd666b45
tree85f88580a3191bfc3730804bc76594b7da6d70b7
parentca6afa1630ee634944fcfd065a38182fb14dd484
LayoutTests:

        Reviewed by Mitz and Geoff.

        Test for <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)

        * fast/forms/textarea-scrollbar-expected.checksum: Added.
        * fast/forms/textarea-scrollbar-expected.png: Added.
        * fast/forms/textarea-scrollbar-expected.txt: Added.
        * fast/forms/textarea-scrollbar.html: Added.

WebCore:

        Reviewed by Mitz and Geoff.

        - Fix for:
        <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
        <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
        <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages

        Test: fast/forms/textarea-scrollbar.html

        To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
        a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.

        * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::RenderTextControl):
        (WebCore::RenderTextControl::setStyle):
        (WebCore::RenderTextControl::createDivStyle):
        (WebCore::RenderTextControl::updateFromElement):
        (WebCore::RenderTextControl::calcHeight):
        (WebCore::RenderTextControl::baselinePosition):
        (WebCore::RenderTextControl::nodeAtPoint):
        (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
        (WebCore::RenderTextControl::scrollWidth):
        (WebCore::RenderTextControl::scrollHeight):
        (WebCore::RenderTextControl::scrollLeft):
        (WebCore::RenderTextControl::scrollTop):

        * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/forms/textarea-scrollbar-expected.checksum [new file with mode: 0644]
LayoutTests/fast/forms/textarea-scrollbar-expected.png [new file with mode: 0644]
LayoutTests/fast/forms/textarea-scrollbar-expected.txt [new file with mode: 0644]
LayoutTests/fast/forms/textarea-scrollbar.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/rendering/RenderObject.cpp
WebCore/rendering/RenderTextControl.cpp
WebCore/rendering/RenderTextControl.h