2008-02-19 Alp Toker <alp@atoker.com>
authoralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Feb 2008 13:05:03 +0000 (13:05 +0000)
committeralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Feb 2008 13:05:03 +0000 (13:05 +0000)
commitf03015252528fbc360129b58f30e1046facca746
tree2d9724208f3620b0f9d312c239ac3a406aae11c5
parent04a29e17bc35d11186ea0dacc08673ce669e20b2
2008-02-19  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        http://bugs.webkit.org/show_bug.cgi?id=16863
        [GTK] tab focusing doesn't work

        GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
        the meta key state.

        Use GDK_META_MASK where available, otherwise do not support the meta
        key. This matches the behaviour of other applications.

        Also add a comment noting that the platform event constructors need to
        be kept in sync (it's not obvious that there are multiple places that
        check the key state).

        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
        * platform/gtk/MouseEventGtk.cpp:
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        * platform/gtk/WheelEventGtk.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore/ChangeLog
WebCore/platform/gtk/KeyEventGtk.cpp
WebCore/platform/gtk/MouseEventGtk.cpp
WebCore/platform/gtk/WheelEventGtk.cpp