Reviewed by Justin Garcia.
authorap@webkit.org <ap@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Nov 2007 05:49:44 +0000 (05:49 +0000)
committerap@webkit.org <ap@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Nov 2007 05:49:44 +0000 (05:49 +0000)
commitef921a76ae56195c652f2db2bbec9107a44f07f8
treecab30a8c4f21ab608dcdec68a8b9e9143115168f
parent4c6c5f266abd9d79e7a29bbb50145a7d6f111a62
    Reviewed by Justin Garcia.

        http://bugs.webkit.org/show_bug.cgi?id=15781
        REGRESSION: Ligatures fail to form when typing in Devanagari (because WebKit can't handle
        a marked range that covers half of a composed character sequence)

        Test: platform/mac/editing/input/devanagari-ligature.html

        This fix is somewhat of a hack, as it asks editing commands to work with invalid selections.
        However, this is not entirely new for them, as Roman accents are typed in a similar manner.

        In the future, we probably want to make commands work with ranges (or Positions explicitly).

        * editing/Editor.cpp:
        (WebCore::Editor::selectComposition): Force selection to composition range.
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input): Force ending selection to inserted text range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/platform/mac/editing/input/devanagari-ligature-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/editing/input/devanagari-ligature-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/editing/input/devanagari-ligature-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/editing/input/devanagari-ligature.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/editing/Editor.cpp
WebCore/editing/InsertTextCommand.cpp