Text-combine erroneously draws vertically after non-layout-causing style change
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 Apr 2015 22:36:56 +0000 (22:36 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 Apr 2015 22:36:56 +0000 (22:36 +0000)
commiteb0190b7fa9f03aad4947ae746740e6050ccd3ed
tree8d731e702b97c9fdcbbe808ba4ee2043024638ff
parent464004e149e192e54b96439d2d89acb662a1d78b
Text-combine erroneously draws vertically after non-layout-causing style change
https://bugs.webkit.org/show_bug.cgi?id=143461
<rdar://problem/19285490>

Reviewed by Darin Adler.

Source/WebCore:

RenderCombineText::styleDidChange() unconditionally uncombines its text. Layout then
recombines it. However, if there is a style change that does not cause layout, the
RenderCombineText will be left uncombined until the next layout.

Test: fast/text/text-combine-style-change-no-layout.html

* rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

* fast/text/text-combine-style-change-no-layout-expected.html: Added.
* fast/text/text-combine-style-change-no-layout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@182609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/text/text-combine-style-change-no-layout-expected.html [new file with mode: 0644]
LayoutTests/fast/text/text-combine-style-change-no-layout.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderCombineText.cpp