LayoutTests:
authordarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Apr 2006 05:57:30 +0000 (05:57 +0000)
committerdarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Apr 2006 05:57:30 +0000 (05:57 +0000)
commite723341f928668655c524d30322aaaf57fe5d2fc
treebfd56eb11388673763adbcfb1497a6c89e450927
parent8fba6e016db3a10ea9bb0c4588c0c27397636b0b
LayoutTests:

        Reviewed by Adele.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8111
          REGRESSION (NativeTextField): first click in form field on weather.com leaves focus
          but no caret

        - updated results for improved dumping of selection location in DumpRenderTree

        * fast/forms/input-text-self-emptying-click-expected.checksum: Added.
        * fast/forms/input-text-self-emptying-click-expected.png: Added.
        * fast/forms/input-text-self-emptying-click-expected.txt: Added.
        * fast/forms/input-text-self-emptying-click.html: Added.

        * editing/selection/3690703-2-expected.txt: Updated.
        * fast/forms/input-appearance-focus-expected.txt: Updated.
        * fast/forms/input-appearance-readonly-expected.txt: Updated.
        * fast/forms/input-appearance-selection-expected.txt: Updated.
        * fast/forms/input-paste-undo-expected.txt: Updated.
        * fast/forms/input-text-double-click-expected.txt: Updated.
        * fast/forms/input-text-option-delete-expected.txt: Updated.
        * fast/forms/input-text-scroll-left-on-blur-expected.txt: Updated.
        * fast/forms/plaintext-mode-2-expected.txt: Updated.

WebCore:

        Reviewed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8111
          REGRESSION (NativeTextField): first click in form field on weather.com leaves focus
          but no caret

        Test: fast/forms/input-text-self-emptying-click.html

        * page/MouseEventWithHitTestResults.h: Removed url, target, m_url and m_target,
        replacing them with isOverLink and m_isOverLink. Replaced innerNode with targetNode,
        and added logic to handle the case where the target node is removed from the document
        but the element the target node was in is still inside the document.
        * page/MouseEventWithHitTestResults.cpp: Added.

        * WebCore.xcodeproj/project.pbxproj: Added MouseEventWithHitTestResults.cpp.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.

        * kwq/RenderTreeAsText.cpp: (nodePosition): Added a call to shadowParentNode so we
        correctly dump positions within shadow trees. This was needed to give a good result
        from my new test for this bug.

        * dom/Document.cpp:
        (WebCore::Document::prepareMouseEvent): Update to pass fewer parameters to the
        constructor for MouseEventWithHitTestResults. Now takes isOverLink boolean, and no
        longer takes href and target parameters.

        * page/Frame.cpp:
        (WebCore::Frame::handleMousePressEventDoubleClick): Use new name targetNode, instead
        of old name innerNode.
        (WebCore::Frame::handleMousePressEventTripleClick): Ditto.
        (WebCore::Frame::handleMousePressEventSingleClick): Ditto. Also change code to check
        if over a link to use !isOverLink instead of url.isNull.
        (WebCore::Frame::handleMousePressEvent): Ditto. Also remove unused "url" local variable.
        (WebCore::Frame::handleMouseMoveEvent): Ditto.
        (WebCore::Frame::handleMouseReleaseEvent): Ditto.
        (WebCore::Frame::passWidgetMouseDownEventToWidget): Ditto.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::handleMousePressEvent): Use new name targetNode, instead of old
        name innerNode.
        (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
        (WebCore::FrameMac::passSubframeEventToSubframe): Ditto.
        (WebCore::FrameMac::sendContextMenuEvent): Ditto.

        * page/FrameView.cpp:
        (WebCore::subframeForEvent): Use new name targetNode, instead of old name innerNode.
        (WebCore::FrameView::handleMousePressEvent): Ditto.
        (WebCore::FrameView::handleMouseDoubleClickEvent): Ditto.
        (WebCore::selectCursor): Ditto. Also change code to check if over a link to use
        isOverLink instead of !url.isNull.
        (WebCore::FrameView::handleMouseMoveEvent): Ditto.
        (WebCore::FrameView::handleMouseReleaseEvent): Ditto.
        (WebCore::FrameView::updateDragAndDrop): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
24 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/selection/3690703-2-expected.txt
LayoutTests/fast/forms/input-appearance-focus-expected.txt
LayoutTests/fast/forms/input-appearance-readonly-expected.txt
LayoutTests/fast/forms/input-appearance-selection-expected.txt
LayoutTests/fast/forms/input-paste-undo-expected.txt
LayoutTests/fast/forms/input-text-double-click-expected.txt
LayoutTests/fast/forms/input-text-option-delete-expected.txt
LayoutTests/fast/forms/input-text-scroll-left-on-blur-expected.txt
LayoutTests/fast/forms/input-text-self-emptying-click-expected.checksum [new file with mode: 0644]
LayoutTests/fast/forms/input-text-self-emptying-click-expected.png [new file with mode: 0644]
LayoutTests/fast/forms/input-text-self-emptying-click-expected.txt [new file with mode: 0644]
LayoutTests/fast/forms/input-text-self-emptying-click.html [new file with mode: 0644]
LayoutTests/fast/forms/plaintext-mode-2-expected.txt
WebCore/ChangeLog
WebCore/WebCore.vcproj/WebCore/WebCore.vcproj
WebCore/WebCore.xcodeproj/project.pbxproj
WebCore/bridge/mac/FrameMac.mm
WebCore/dom/Document.cpp
WebCore/kwq/RenderTreeAsText.cpp
WebCore/page/Frame.cpp
WebCore/page/FrameView.cpp
WebCore/page/MouseEventWithHitTestResults.cpp [new file with mode: 0644]
WebCore/page/MouseEventWithHitTestResults.h