LayoutTests:
authorjusting <justing@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 28 Mar 2006 11:30:44 +0000 (11:30 +0000)
committerjusting <justing@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 28 Mar 2006 11:30:44 +0000 (11:30 +0000)
commite33e2f7433ba0e5ec2822814eb19e26d308e2e2e
tree41cb4bd0a2a03437fd4cd60efb33fc6b712d44dd
parent7ed704b41e01e3ee4f1a7f067d95665f50dc5f39
LayoutTests:

        Reviewed by mjs

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7152>
        REGRESSION: Select All does not highlight table if it's last in the document

        * editing/selection/7152-1-expected.checksum: Added.
        * editing/selection/7152-1-expected.png: Added.
        * editing/selection/7152-1-expected.txt: Added.
        * editing/selection/7152-1.html: Added.
        * editing/selection/7152-2-expected.checksum: Added.
        * editing/selection/7152-2-expected.png: Added.
        * editing/selection/7152-2-expected.txt: Added.
        * editing/selection/7152-2.html: Added.

WebCore:

        Reviewed by mjs

        <http://bugzilla.opendarwin.org/attachment.cgi?id=7322>
        REGRESSION: Select All does not highlight table if it's last in the document

        * rendering/RenderCanvas.cpp:
        (WebCore::rendererAfterPosition):
        Added, returns the render object that a pre-order traversal over a range
        of render objects ending at the input position should stop at.
        (WebCore::RenderCanvas::selectionRect):
        Stop at rendererAfterPosition(m_selectionEnd, m_selectionEndPos), moved code
        for traversal to nextInPreOrder. Also, the travesal doesn't need to fetch the
        next object before doing work, since the work it does will never change what
        the next object in the traversal will be.
        (WebCore::RenderCanvas::setSelection): Ditto.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::nextInPreOrder): Renamed from nextRenderer, cleaned up the logic a little.
        (WebCore::RenderObject::nextInPreOrderAfterChildren): Added.
        (WebCore::RenderObject::previousInPreOrder): Renamed from previousRenderer.
        (WebCore::RenderObject::childAt): Added.
        * rendering/RenderObject.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::setText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
14 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/selection/7152-1-expected.checksum [new file with mode: 0644]
LayoutTests/editing/selection/7152-1-expected.png [new file with mode: 0644]
LayoutTests/editing/selection/7152-1-expected.txt [new file with mode: 0644]
LayoutTests/editing/selection/7152-1.html [new file with mode: 0644]
LayoutTests/editing/selection/7152-2-expected.checksum [new file with mode: 0644]
LayoutTests/editing/selection/7152-2-expected.png [new file with mode: 0644]
LayoutTests/editing/selection/7152-2-expected.txt [new file with mode: 0644]
LayoutTests/editing/selection/7152-2.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/rendering/RenderCanvas.cpp
WebCore/rendering/RenderObject.cpp
WebCore/rendering/RenderObject.h
WebCore/rendering/RenderText.cpp