LayoutTests:
Reviewed by Justin
* editing/execCommand/create-list-from-range-selection-expected.checksum:
* editing/execCommand/create-list-from-range-selection-expected.png:
* editing/execCommand/create-list-from-range-selection-expected.txt:
* editing/execCommand/create-list-from-range-selection.html:
This test's results were broken by using rangeCompliantEquivalent at
appropriate places in CompositeEditCommand.cpp::moveParagraphs(), presumably
by revealing a different bug. Justin is going to look into this; for now I've
updated the result so that it won't appear to fail for others.
* editing/execCommand/create-list-with-hr-expected.checksum:
* editing/execCommand/create-list-with-hr-expected.png:
* editing/execCommand/create-list-with-hr-expected.txt:
* editing/execCommand/create-list-with-hr.html:
This test's results were improved by using rangeCompliantEquivalent at
appropriate places in CompositeEditCommand.cpp::moveParagraphs() -- it used
to create an extra <div>, and now it does not.
WebCore:
Reviewed by Justin
With Darin, fixed a problem in the Range constructors found while implementing grammar checking.
That revealed another problem in the layout tests involving bad parameters passed to the Range
constructors.
With these fixes in place, one layout test (editing/execCommand/create-list-from-range-selection.html)
no longer works as intended. This is apparently due to yet another bug being flushed out somewhere.
I'm going to update the results for that test and file a separate radar about it, which Justin will
investigate.
* dom/Position.h:
removed equivalentRangeCompliantPosition(), which was declared but not implemented or called.
* dom/Range.cpp:
(WebCore::Range::Range):
Call setStart and setEnd in the two Range constructors that take parameters, rather than just
directly setting the instance variables. This makes Range perform the boundary checks and
compensations that the DOM spec requires.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):
Use rangeCompliantEquivalent() on "editing-style" Positions before creating Ranges from them.
* editing/TextIterator.cpp:
(WebCore::TextIterator::TextIterator):
Assert that the boundary points of the range are valid.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc