WebCore:
authordarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Sep 2007 15:38:58 +0000 (15:38 +0000)
committerdarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Sep 2007 15:38:58 +0000 (15:38 +0000)
commitdc6e0adb8506613b253189d0d1776896a3d6c83e
tree49210bdba3d4f88723ac245e98a05303b9b37cb9
parentedc2176c474c21f826ed3ebd07eb4d7fec81cc21
WebCore:

        Reviewed by Mitz and Kevin Decker.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15197
          <rdar://problem/5478271> REGRESSION: Some Yahoo text entry fields
          render as lines rather than text entry boxes

        Test: fast/forms/textarea-rows-cols.html

        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Use constants for the default number
        of rows and columns.
        (WebCore::HTMLTextAreaElement::parseMappedAttribute): If rows/cols attribute has a value
        that's missing, non-numeric, or zero, then use the default value. Also check for the
        case where the effective value of the attribute isn't changing.

LayoutTests:

        Reviewed by Mitz and Kevin Decker.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15197
          <rdar://problem/5478271> REGRESSION: Some Yahoo text entry fields
          render as lines rather than text entry boxes

        * fast/forms/textarea-rows-cols.html: Added.
        * platform/mac/fast/forms/textarea-rows-cols-expected.checksum: Added.
        * platform/mac/fast/forms/textarea-rows-cols-expected.png: Added.
        * platform/mac/fast/forms/textarea-rows-cols-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/forms/textarea-rows-cols.html [new file with mode: 0644]
LayoutTests/platform/mac/fast/forms/textarea-rows-cols-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/forms/textarea-rows-cols-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/forms/textarea-rows-cols-expected.txt [new file with mode: 0644]
WebCore/ChangeLog
WebCore/html/HTMLTextAreaElement.cpp