gtk:
Reviewed by Geoff Garen.
changes to keep the build from breaking
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::createFrame):
* WebCoreSupport/FrameLoaderClientGtk.h:
qt:
Reviewed by Geoff Garen.
changes to keep the build from breaking
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createFrame):
* WebCoreSupport/FrameLoaderClientQt.h:
WebCore:
Reviewed by Geoff Garen.
Fixed <rdar://
5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT
createFrame() now returns a RefPtr instead of a raw Frame pointer.
Making this change improves the way we handle frames on Windows webkit.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadSubframe):
* loader/FrameLoaderClient.h:
* platform/graphics/svg/SVGImageEmptyClients.h:
(WebCore::SVGEmptyFrameLoaderClient::createFrame):
WebKit:
Reviewed by Geoff Garen.
Fixed <rdar://
5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT
createFrame() now returns a RefPtr instead of a raw Frame pointer.
Making this change improves the way we handle frames on Windows WebKit.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createFrame):
win:
Reviewed by Geoff Garen.
Fixed <rdar://
5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT
* WebFrame.cpp:
(WebFrame::createFrame):
The crash was caused by the early destruction of the subframe. To resolve this issue,
the manual deref of the child frame that occurs in between being appended to the
frametree and being used in loadURLIntoChild wasn't exactly incorrect, but just needed
to be moved until after loadURLIntoChild. This hasn't been a problem for other uses of
child frames because this test case involves removing a child frame immediately after
loading it, all in an onload handler. Even better than just moving the deref would be
to change the signature of createFrame to use a RefPtr<Frame> so that a manual deref isn't
necessary. This is what was done in this patch.
* WebFrame.h:
createFrame() now returns a RefPtr instead of a raw Frame pointer.
Making this change improves the way we handle frames on Windows WebKit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc