Remove -webkit-color-correction CSS property
https://bugs.webkit.org/show_bug.cgi?id=147812
Reviewed by Maciej Stachowiak.
Source/WebCore:
Covered by existing tests.
I am doing some general cleanup of handling of color spaces in WebKit.
This removes the obsolete web-visible property that allowed clients to
get color correction on older Apple platforms where we chose not to do
it all the time for performance reasons. Currently, it has no effect on
any supported platform.
Now that this property is removed, a website can detect that it's not
there if it uses getComputedStyle, but I don't expect this to have
significant compatibility fallout. It's harmless to continue using the
property in legacy content or websites that have not been updated, since
unknown property names are ignored and it had no effect before anyway.
* css/CSSComputedStyleDeclaration.cpp: Removed
CSSPropertyWebkitColorCorrection from the list of computed properties.
(WebCore::ComputedStyleExtractor::propertyValue): Removed the
CSSPropertyWebkitColorCorrection case.
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue): Removed the
CSSPropertyWebkitColorCorrection case.
(WebCore::isKeywordPropertyID): Ditto.
(WebCore::CSSParser::parseValue): Ditto.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Deleted the overload
of this that converts a ColorSpace to a CSSPrimitiveValue.
(WebCore::CSSPrimitiveValue::operator ColorSpace): Deleted.
* css/CSSPropertyNames.in: Removed -webkit-color-correction.
* css/CSSValueKeywords.in: Removed the -webkit-color-correction section,
which contained sRGB.
* css/SVGCSSValueKeywords.in: Uncommented sRGB now that it's not shared
with -webkit-color-correction.
* rendering/style/RenderStyle.h: Removed setColorSpace and initialColorSpace.
Kept colorSpace around for now, but it simply returns ColorSpaceSRGB.
This prevents us from needing to touch every single call site that passes
the color space in to functions in the platform graphics abstraction.
We'll touch most of those call sites when we change Color to include the
color space and eventually we can delete this.
* rendering/style/StyleRareInheritedData.cpp: Deleted colorSpace.
(WebCore::StyleRareInheritedData::StyleRareInheritedData): Deleted
code to initialize colorSpace and to copy colorSpace.
(WebCore::StyleRareInheritedData::operator==): Deleted code to compare
colorSpace.
LayoutTests:
Given that -webkit-color-correction had no effect on rendering on any platform in any
configuration we covered, it's amazing how many tests we had for it.
* fast/css/getComputedStyle/computed-style-expected.txt: Removed expected results for
-webkit-color-correction property.
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
* svg/css/getComputedStyle-basic-expected.txt: Ditto.
* fast/css/getComputedStyle/resources/property-names.js: Removed -webkit-color-correction.
* fast/css/color-correction-backgrounds-and-text.html: Removed.
* fast/css/color-correction-on-background-image.html: Removed.
* fast/css/color-correction-on-backgrounds.html: Removed.
* fast/css/color-correction-on-box-shadow.html: Removed.
* fast/css/color-correction-on-text-shadow.html: Removed.
* fast/css/color-correction-on-text.html: Removed.
* fast/css/color-correction-untagged-images.html: Removed.
* fast/css/color-correction.html: Removed.
* fast/css/parsing-color-correction-expected.txt: Removed.
* fast/css/parsing-color-correction.html: Removed.
* fast/css/resources/parsing-color-correction.js: Removed.
* platform/efl/fast/css/color-correction-backgrounds-and-text-expected.png: Removed.
* platform/efl/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
* platform/efl/fast/css/color-correction-expected.png: Removed.
* platform/efl/fast/css/color-correction-expected.txt: Removed.
* platform/efl/fast/css/color-correction-on-background-image-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-background-image-expected.txt: Removed.
* platform/efl/fast/css/color-correction-on-backgrounds-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
* platform/efl/fast/css/color-correction-on-box-shadow-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
* platform/efl/fast/css/color-correction-on-text-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-text-expected.txt: Removed.
* platform/efl/fast/css/color-correction-on-text-shadow-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
* platform/efl/fast/css/color-correction-untagged-images-expected.png: Removed.
* platform/efl/fast/css/color-correction-untagged-images-expected.txt: Removed.
* platform/gtk/fast/css/color-correction-backgrounds-and-text-expected.png: Removed.
* platform/gtk/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
* platform/gtk/fast/css/color-correction-expected.png: Removed.
* platform/gtk/fast/css/color-correction-expected.txt: Removed.
* platform/gtk/fast/css/color-correction-on-background-image-expected.png: Removed.
* platform/gtk/fast/css/color-correction-on-background-image-expected.txt: Removed.
* platform/gtk/fast/css/color-correction-on-backgrounds-expected.png: Removed.
* platform/gtk/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
* platform/gtk/fast/css/color-correction-on-box-shadow-expected.png: Removed.
* platform/gtk/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
* platform/gtk/fast/css/color-correction-on-text-expected.png: Removed.
* platform/gtk/fast/css/color-correction-on-text-expected.txt: Removed.
* platform/gtk/fast/css/color-correction-on-text-shadow-expected.png: Removed.
* platform/gtk/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
* platform/gtk/fast/css/color-correction-untagged-images-expected.png: Removed.
* platform/gtk/fast/css/color-correction-untagged-images-expected.txt: Removed.
* platform/ios-simulator-wk2/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
* platform/ios-simulator-wk2/fast/css/color-correction-expected.txt: Removed.
* platform/ios-simulator-wk2/fast/css/color-correction-on-background-image-expected.txt: Removed.
* platform/ios-simulator-wk2/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
* platform/ios-simulator-wk2/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
* platform/ios-simulator-wk2/fast/css/color-correction-on-text-expected.txt: Removed.
* platform/ios-simulator-wk2/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
* platform/ios-simulator-wk2/fast/css/color-correction-untagged-images-expected.txt: Removed.
* platform/ios-simulator/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
* platform/ios-simulator/fast/css/color-correction-expected.txt: Removed.
* platform/ios-simulator/fast/css/color-correction-on-background-image-expected.txt: Removed.
* platform/ios-simulator/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
* platform/ios-simulator/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
* platform/ios-simulator/fast/css/color-correction-on-text-expected.txt: Removed.
* platform/ios-simulator/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
* platform/ios-simulator/fast/css/color-correction-untagged-images-expected.txt: Removed.
* platform/mac/fast/css/color-correction-backgrounds-and-text-expected.png: Removed.
* platform/mac/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
* platform/mac/fast/css/color-correction-expected.png: Removed.
* platform/mac/fast/css/color-correction-expected.txt: Removed.
* platform/mac/fast/css/color-correction-on-background-image-expected.png: Removed.
* platform/mac/fast/css/color-correction-on-background-image-expected.txt: Removed.
* platform/mac/fast/css/color-correction-on-backgrounds-expected.png: Removed.
* platform/mac/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
* platform/mac/fast/css/color-correction-on-box-shadow-expected.png: Removed.
* platform/mac/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
* platform/mac/fast/css/color-correction-on-text-expected.png: Removed.
* platform/mac/fast/css/color-correction-on-text-expected.txt: Removed.
* platform/mac/fast/css/color-correction-on-text-shadow-expected.png: Removed.
* platform/mac/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
* platform/mac/fast/css/color-correction-untagged-images-expected.png: Removed.
* platform/mac/fast/css/color-correction-untagged-images-expected.txt: Removed.
* platform/win/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
* platform/win/fast/css/color-correction-expected.txt: Removed.
* platform/win/fast/css/color-correction-on-background-image-expected.txt: Removed.
* platform/win/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
* platform/win/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
* platform/win/fast/css/color-correction-on-text-expected.txt: Removed.
* platform/win/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
* platform/win/fast/css/color-correction-untagged-images-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@188202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc