LayoutTests:
authorjusting <justing@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Sep 2006 19:52:27 +0000 (19:52 +0000)
committerjusting <justing@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Sep 2006 19:52:27 +0000 (19:52 +0000)
commitcd716613df733a9b05e1a30f9aad561cd0942883
tree3025bf34a277f112feab571f37fd4798f212054e
parent220e38550460cd180e5627208078ceffd2ca01a7
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4655880> Up/Down arrows skip over To Do

        * editing/selection/mixed-editability-3-expected.checksum: Added.
        * editing/selection/mixed-editability-3-expected.png: Added.
        * editing/selection/mixed-editability-3-expected.txt: Added.
        * editing/selection/mixed-editability-3.html: Added.
        * editing/selection/mixed-editability-4-expected.checksum: Added.
        * editing/selection/mixed-editability-4-expected.png: Added.
        * editing/selection/mixed-editability-4-expected.txt: Added.
        * editing/selection/mixed-editability-4.html: Added.
        * editing/selection/mixed-editability-5-expected.checksum: Added.
        * editing/selection/mixed-editability-5-expected.png: Added.
        * editing/selection/mixed-editability-5-expected.txt: Added.
        * editing/selection/mixed-editability-5.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4655880> Up/Down arrows skip over To Do

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
        * dom/Node.cpp: Removed the unused inSameRootEditableElement.
        * dom/Node.h:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
        * editing/visible_units.cpp:
        (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from
        editable content into editable content that's embedded in non-editable content.
        (WebCore::nextLinePosition): Ditto.
        (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot.
        This is the behavior that callers desire.  This fixes Command + Up/Down.
        (WebCore::endOfEditableContent): Ditto.
        * editing/visible_units.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
21 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/selection/mixed-editability-3-expected.checksum [new file with mode: 0644]
LayoutTests/editing/selection/mixed-editability-3-expected.png [new file with mode: 0644]
LayoutTests/editing/selection/mixed-editability-3-expected.txt [new file with mode: 0644]
LayoutTests/editing/selection/mixed-editability-3.html [new file with mode: 0644]
LayoutTests/editing/selection/mixed-editability-4-expected.checksum [new file with mode: 0644]
LayoutTests/editing/selection/mixed-editability-4-expected.png [new file with mode: 0644]
LayoutTests/editing/selection/mixed-editability-4-expected.txt [new file with mode: 0644]
LayoutTests/editing/selection/mixed-editability-4.html [new file with mode: 0644]
LayoutTests/editing/selection/mixed-editability-5-expected.checksum [new file with mode: 0644]
LayoutTests/editing/selection/mixed-editability-5-expected.png [new file with mode: 0644]
LayoutTests/editing/selection/mixed-editability-5-expected.txt [new file with mode: 0644]
LayoutTests/editing/selection/mixed-editability-5.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/WebCore.xcodeproj/project.pbxproj
WebCore/bridge/mac/WebCoreFrameBridge.mm
WebCore/dom/Node.cpp
WebCore/dom/Node.h
WebCore/editing/SelectionController.cpp
WebCore/editing/visible_units.cpp
WebCore/editing/visible_units.h