Web Inspector: Remove unused / duplicate WebSocket timeline records
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 29 Oct 2015 01:30:16 +0000 (01:30 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 29 Oct 2015 01:30:16 +0000 (01:30 +0000)
commitc6255e7b3bfdbf7469c345d49f2d836be3272269
treec56f52d67ff49d5fded72d84ccdb7ff6ffe34970
parent5f9a72516bfe3ee1f9a9251a777b7dda763b3779
Web Inspector: Remove unused / duplicate WebSocket timeline records
https://bugs.webkit.org/show_bug.cgi?id=150647

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-28
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

* inspector/protocol/Timeline.json:

Source/WebCore:

* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect):
Only send what is needed by inspector now.

* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrame):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrameError):
(WebCore::InspectorInstrumentation::didSendWebSocketFrame):
These can all fast return if there is no frontend because the inspector
doesn't record any information about web sockets until a frontend is connected.
The inspector in this case just sends events to the frontend when things happen.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
(WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
Stop messaging the Timeline agent, we already message the Resource agent.

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCreateWebSocket): Deleted.
(WebCore::InspectorTimelineAgent::willSendWebSocketHandshakeRequest): Deleted.
(WebCore::InspectorTimelineAgent::didReceiveWebSocketHandshakeResponse): Deleted.
(WebCore::InspectorTimelineAgent::didDestroyWebSocket): Deleted.
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.h:
(WebCore::TimelineRecordFactory::createWebSocketCreateData): Deleted.
(WebCore::TimelineRecordFactory::createGenericWebSocketData): Deleted.
This is all duplicate information from the network domain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/inspector/protocol/Timeline.json
Source/WebCore/ChangeLog
Source/WebCore/Modules/websockets/WebSocketChannel.cpp
Source/WebCore/inspector/InspectorInstrumentation.cpp
Source/WebCore/inspector/InspectorInstrumentation.h
Source/WebCore/inspector/InspectorTimelineAgent.cpp
Source/WebCore/inspector/InspectorTimelineAgent.h
Source/WebCore/inspector/TimelineRecordFactory.h