Bring Int/Float graphics classes closer to parity
authorleviw@chromium.org <leviw@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Jul 2011 23:18:27 +0000 (23:18 +0000)
committerleviw@chromium.org <leviw@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 Jul 2011 23:18:27 +0000 (23:18 +0000)
commitc37c4c4e9f7cf2872178b60dabee2f85d3957b55
tree9860d6b9bb1e65625c8a81f33a187a60c1abe1bd
parent56b54f84671f8858acd3727afdb7794d1a621852
Bring Int/Float graphics classes closer to parity
https://bugs.webkit.org/show_bug.cgi?id=64833

Reviewed by James Robinson.

In preparation of switching to Floating point data structures, bringing the
functionality and method names of the Int/Float graphics classes close together.

Also fixing some compiler errors when using Floats for layout units along the way.

No new tests, no functionality change.

* page/FrameView.cpp:
(WebCore::FrameView::convertFromRenderer):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(WebCore::ScrollView::convertChildToSelf):
(WebCore::ScrollView::convertSelfToChild):
* platform/graphics/FloatPoint.h:
(WebCore::operator-): Adding a single-parameter version.
* platform/graphics/FloatSize.cpp:
(WebCore::FloatSize::isZero): Adding isZero that uses epsilon for floats.
* platform/graphics/FloatSize.h:
* platform/graphics/IntPoint.h:
(WebCore::IntPoint::moveBy): Renaming IntPoint version to moveBy to mirror FloatPoint.
* platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::Radii::expand): Switching to specific templatized max.
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::requestedRegionOfInputImageData):
* rendering/RenderBlock.cpp: Moving outstanding Int* functions to Layout units.
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::logicalRectToPhysicalRect):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionForPoint):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::subtractCaptionRect):
* rendering/RenderTable.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleOrColLogicalWidth):
(WebCore::RenderTableCell::setOverrideSizeFromRowHeight):
(WebCore::RenderTableCell::paintCollapsedBorder):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
* rendering/RenderTableCell.h:
* rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
(WebCore::setAscentAndDescent):
* rendering/RootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
20 files changed:
Source/WebCore/ChangeLog
Source/WebCore/page/FrameView.cpp
Source/WebCore/platform/ScrollView.cpp
Source/WebCore/platform/ScrollView.h
Source/WebCore/platform/graphics/FloatPoint.h
Source/WebCore/platform/graphics/FloatSize.cpp
Source/WebCore/platform/graphics/FloatSize.h
Source/WebCore/platform/graphics/IntPoint.h
Source/WebCore/platform/graphics/RoundedRect.cpp
Source/WebCore/platform/graphics/filters/FilterEffect.cpp
Source/WebCore/rendering/RenderBlock.cpp
Source/WebCore/rendering/RenderBlock.h
Source/WebCore/rendering/RenderBox.cpp
Source/WebCore/rendering/RenderTable.cpp
Source/WebCore/rendering/RenderTable.h
Source/WebCore/rendering/RenderTableCell.cpp
Source/WebCore/rendering/RenderTableCell.h
Source/WebCore/rendering/RenderView.h
Source/WebCore/rendering/RootInlineBox.cpp
Source/WebCore/rendering/RootInlineBox.h