Stop using dispatch_set_target_queue()
authorddkilzer@apple.com <ddkilzer@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 23 Mar 2018 19:06:35 +0000 (19:06 +0000)
committerddkilzer@apple.com <ddkilzer@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 23 Mar 2018 19:06:35 +0000 (19:06 +0000)
commitc1f5f02f7f627a52d56d76d323bef2fed0205439
tree1f99ced752113a902c54102ca8aae4e570a1fd0f
parent09834c05a8dcd465bdbcb66b816aa9e3c7f049de
Stop using dispatch_set_target_queue()
<https://webkit.org/b/183908>
<rdar://problem/33553533>

Reviewed by Daniel Bates.

Source/ThirdParty/libwebrtc:

* Source/webrtc/rtc_base/task_queue_gcd.cc: Remove use of
dispatch_set_target_queue() by changing dispatch_queue_create()
to dispatch_queue_create_with_target().
* WebKit/0009-Remove-dispatch_set_target_queue.patch: Add patch.
Filed this to track upstreaming the change:
<https://bugs.chromium.org/p/webrtc/issues/detail?id=9055>
* WebKit/patch-libwebrtc: Delete empty patch file.

Source/WebCore:

No new tests since no change in behavior.

* platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::globaVideoCaptureSerialQueue): Remove use of
dispatch_set_target_queue() by changing dispatch_queue_create()
to dispatch_queue_create_with_target().

Source/WebKit:

* NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:
(WebKit::NetworkCache::IOChannel::IOChannel): Remove the call to
dispatch_set_target_queue() since this is handled in the
dispatch_io_create() call above.

Source/WTF:

* wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::WorkQueue::platformInitialize): Remove !HAVE(QOS_CLASSES)
code path since it's never used now that HAVE(QOS_CLASSES) is
equivalent to PLATFORM(COCOA) in <wtf/Platform.h>.

Tools:

* Scripts/webkitpy/style/checkers/cpp.py:
(check_language): Add check for use of
dispatch_set_target_queue().
(CppChecker): Add 'runtime/dispatch_set_target_queue' category.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest): Add test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
13 files changed:
Source/ThirdParty/libwebrtc/ChangeLog
Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/task_queue_gcd.cc
Source/ThirdParty/libwebrtc/WebKit/0009-Remove-dispatch_set_target_queue.patch [new file with mode: 0644]
Source/ThirdParty/libwebrtc/WebKit/patch-libwebrtc [deleted file]
Source/WTF/ChangeLog
Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp
Source/WebCore/ChangeLog
Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm
Source/WebKit/ChangeLog
Source/WebKit/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm
Tools/ChangeLog
Tools/Scripts/webkitpy/style/checkers/cpp.py
Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py