Web Inspector: Create a container class for SidebarPane instances
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Feb 2013 18:19:31 +0000 (18:19 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Feb 2013 18:19:31 +0000 (18:19 +0000)
commitc18ae79075ff626b3c195306a6eda96db38a8146
tree53c664b43b4f15f66f5f08fe0b8777b71706d818
parent54804d4b211f1170fa022db808a31ff0c21f23d0
Web Inspector: Create a container class for SidebarPane instances
https://bugs.webkit.org/show_bug.cgi?id=108183

Source/WebCore:

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

SidebarPaneStack is responsible for pane title bar and expand/collapse behavior (previously handled by SidebarPane).
SidebarPanes are inserted into DOM lazily and can belong to more than one container.
SidebarPane is ready to be displayed in other types of containers (such as tabbed pane as requested in https://bugs.webkit.org/show_bug.cgi?id=107552).
There should be no visible changes except for one: DOM breakpoint pane expand/collapse state is no longer
shared between Elements and Sources sidebars.

* inspector/front-end/AuditResultView.js:
(WebInspector.AuditResultView):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.updateStyles):
(WebInspector.ElementsPanel.prototype.updateMetrics):
(WebInspector.ElementsPanel.prototype.updateProperties):
(WebInspector.ElementsPanel.prototype.updateEventListeners):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
* inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.title):
(WebInspector.SidebarPane.prototype.prepareContent):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype.setExpandCallback):
(WebInspector.SidebarPane.prototype.setShowCallback):
(WebInspector.SidebarPane.prototype.wasShown):
(WebInspector.SidebarPaneStack):
(WebInspector.SidebarPaneStack.prototype.wasShown):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarPaneStack.prototype._addTitle):
(WebInspector.SidebarPaneStack.prototype._attachToPane):
(WebInspector.SidebarPaneStack.prototype._isExpanded):
(WebInspector.SidebarPaneStack.prototype._setExpanded):
(WebInspector.SidebarPaneStack.prototype._onPaneExpanded):
(WebInspector.SidebarPaneStack.prototype._collapsePane):
(WebInspector.SidebarPaneStack.prototype._togglePane):
(WebInspector.SidebarPaneStack.prototype._onTitleKeyDown):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype.set _createNewRule):
(WebInspector.ComputedStyleSidebarPane.prototype.prepareContent):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSidebarPane):
(WebInspector.WatchExpressionsSidebarPane.prototype.wasShown):
(WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
(WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):
* inspector/front-end/inspector.css:
(.pane-title + .pane-title, .pane:not(.visible) + .pane-title, .pane-title:first-of-type):
(.pane-title):
(.pane-title:active):
(.pane-title::before):
(.pane-title.expanded::before):
(.pane-title > select):
(.pane-title > select:hover):
(.pane-title > select:active):
(.pane-title > select.select-settings):
(.pane-title > select.select-filter):
(.pane-title > select > option, .pane-title > select > hr):
(.pane-title > .pane-title-button):
(.pane-title > .pane-title-button:hover):
(.pane-title > .pane-title-button:active, .pane-title > .pane-title-button.toggled):
(.pane-title > .pane-title-button.add):
(.pane-title > .pane-title-button.element-state):
(.pane-title > .pane-title-button.refresh):
(.pane.visible > .body):
(.pane.visible:nth-last-of-type(1)):
(.panel-enabler-view button:not(.status-bar-item), .pane-title-button, button.show-all-nodes):
(.panel-enabler-view button:active:not(.status-bar-item), .pane-title-button:active, button.show-all-nodes:active):
(body.inactive .panel-enabler-view button:not(.status-bar-item), .panel-enabler-view button:disabled:not(.status-bar-item), body.inactive .pane-title-button, .pane-title-button:disabled, body.inactive button.show-all-nodes):

LayoutTests:

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.stylesCallback):
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):
* inspector/audits/audits-panel-functional-expected.txt:
* inspector/audits/audits-panel-noimages-functional-expected.txt:
* inspector/debugger/error-in-watch-expressions.html:
* inspector/debugger/properties-special.html:
* inspector/debugger/watch-expressions-panel-switch.html:
* inspector/debugger/watch-expressions-preserve-expansion.html:
* inspector/extensions/extensions-audits-api-expected.txt:
* inspector/extensions/extensions-audits-content-script-expected.txt:
* inspector/extensions/extensions-audits-expected.txt:
* inspector/extensions/extensions-events.html:
* inspector/extensions/extensions-sidebar.html:
* inspector/styles/lazy-computed-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
26 files changed:
LayoutTests/ChangeLog
LayoutTests/http/tests/inspector/elements-test.js
LayoutTests/inspector/audits/audits-panel-functional-expected.txt
LayoutTests/inspector/audits/audits-panel-noimages-functional-expected.txt
LayoutTests/inspector/debugger/error-in-watch-expressions.html
LayoutTests/inspector/debugger/properties-special.html
LayoutTests/inspector/debugger/watch-expressions-panel-switch.html
LayoutTests/inspector/debugger/watch-expressions-preserve-expansion.html
LayoutTests/inspector/extensions/extensions-audits-api-expected.txt
LayoutTests/inspector/extensions/extensions-audits-content-script-expected.txt
LayoutTests/inspector/extensions/extensions-audits-expected.txt
LayoutTests/inspector/extensions/extensions-events.html
LayoutTests/inspector/extensions/extensions-sidebar.html
LayoutTests/inspector/styles/lazy-computed-style.html
Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/AuditResultView.js
Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js
Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js
Source/WebCore/inspector/front-end/ElementsPanel.js
Source/WebCore/inspector/front-end/ExtensionPanel.js
Source/WebCore/inspector/front-end/ExtensionServer.js
Source/WebCore/inspector/front-end/ScriptsPanel.js
Source/WebCore/inspector/front-end/SidebarPane.js
Source/WebCore/inspector/front-end/StylesSidebarPane.js
Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js
Source/WebCore/inspector/front-end/inspector.css