Japanese text in Google search is rendered too low and clipped
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Jun 2014 23:23:46 +0000 (23:23 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Jun 2014 23:23:46 +0000 (23:23 +0000)
commitbe9040d6f6d4ac4d99701f617d5fe784274720ee
tree575db31039a7bcc225fca517104b7e16a1354423
parent6a2c7346c7cddfaed1f5d062378d5ee928cb5c5d
Japanese text in Google search is rendered too low and clipped
https://bugs.webkit.org/show_bug.cgi?id=133595

Reviewed by Simon Fraser.

This is a revert of r155324.

Source/WebCore:
By forcing line-height to be normal, r155324 was forcing WebKit to inspect font metrics
to determine the height of a line. This means that if a fallback font was required to
draw a line of text, and the fallback font had a higher ascent than the primary font,
the entire line of text would be pushed down. If we don't force line-height to be normal,
then we use the line-height value instead, which short circuits this mechanism, thereby
not pushing text down.

No new tests (because this is simply a revert)

* css/html.css:
(input): Deleted.

LayoutTests:
* fast/dom/HTMLInputElement/input-line-height-expected.txt: Removed.
* fast/dom/HTMLInputElement/input-line-height.html: Removed.
* fast/forms/placeholder-position-expected.txt:
* platform/mac/fast/forms/placeholder-position-expected.png:
* platform/mac/fast/forms/placeholder-position-expected.txt:
* platform/mac-mountainlion/fast/forms/placeholder-position-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/dom/HTMLInputElement/input-line-height-expected.txt [deleted file]
LayoutTests/fast/dom/HTMLInputElement/input-line-height.html [deleted file]
LayoutTests/fast/forms/placeholder-position-expected.txt
LayoutTests/platform/mac-mountainlion/fast/forms/placeholder-position-expected.txt
LayoutTests/platform/mac/fast/forms/placeholder-position-expected.png
LayoutTests/platform/mac/fast/forms/placeholder-position-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/css/html.css