Adding block elements to a block and removing them changes the height of the element.
authorenrica@apple.com <enrica@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 12 May 2010 21:24:10 +0000 (21:24 +0000)
committerenrica@apple.com <enrica@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 12 May 2010 21:24:10 +0000 (21:24 +0000)
commitb6c1b6dbd0df7e388efb24cd7b767dbbf6940061
tree4a10a9bae6458209434862f9fb3cebdbb3dca64d
parent100a3a5721336006fc6c96fadc9b5878022c37be
Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.

LayoutTests:

* editing/deleting/delete-block-contents-004-expected.txt: Added.
* editing/deleting/delete-block-contents-004.html: Added.
The following tests have new results because of the height change and because we now have one less renderer after the DOM changes.
* editing/deleting/in-visibly-empty-root-expected.txt:
* platform/mac/editing/deleting/5408255-expected.txt:
* platform/mac/editing/deleting/delete-select-all-001-expected.txt:
* platform/mac/editing/selection/4895428-1-expected.txt:
* platform/mac/editing/selection/4895428-4-expected.txt:
* platform/mac/fast/events/mouseout-dead-node-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/editing/deleting/delete-block-contents-004-expected.txt [new file with mode: 0644]
LayoutTests/editing/deleting/delete-block-contents-004.html [new file with mode: 0644]
LayoutTests/editing/deleting/in-visibly-empty-root-expected.txt
LayoutTests/platform/mac/editing/deleting/5408255-expected.txt
LayoutTests/platform/mac/editing/deleting/delete-select-all-001-expected.txt
LayoutTests/platform/mac/editing/selection/4895428-1-expected.txt
LayoutTests/platform/mac/editing/selection/4895428-4-expected.txt
LayoutTests/platform/mac/fast/events/mouseout-dead-node-expected.txt
WebCore/ChangeLog
WebCore/rendering/RenderBlock.cpp