[iOS] REGRESSION (r187376): Form editing buttons are missing from the Shortcut Bar
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 28 Jul 2015 04:35:29 +0000 (04:35 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 28 Jul 2015 04:35:29 +0000 (04:35 +0000)
commitb410624f6b661e9d05ca5e3a8dd48148f6f3b0fe
tree0450b94c1bcc05735ad894f9e1a64fa62dfa3a57
parent46542a06b4e788ec3000f1706cf92a20b77cc6fd
[iOS] REGRESSION (r187376): Form editing buttons are missing from the Shortcut Bar
https://bugs.webkit.org/show_bug.cgi?id=147351

Reviewed by Adele Peterson.

We were relying on -[WKContentView inputAccessoryView] getting called to initialize the form
accessory view, even when that method would always return nil, as it does on iPad. After
r187376, that method changed to initializing the view only when returning it, which caused
this bug.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _displayFormNodeInputView]): Call the new -_ensureFormAccessoryView from
here, when we are going to need the view.
(-[WKContentView _ensureFormAccessoryView]): Moved initialization code from
-inputAccessoryView here, and removed outdated +instancesRespondToSelector: check.
(-[WKContentView inputAccessoryView]): Now calls through -formAccessoryView.
(-[WKContentView formAccessoryView]): Added call to -_ensureFormAccessoryView here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm