WebCore:
authorhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Mar 2009 17:56:41 +0000 (17:56 +0000)
committerhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Mar 2009 17:56:41 +0000 (17:56 +0000)
commitb325f38dd904380396d0ac5813dbb4c3ccf79552
tree5ee064fa447398c08c201c922974571332a72b0f
parent11c6e512c99d089a43448321b6ef03a6103c6001
WebCore:

2009-03-03  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.

        Make sure to factor clear deltas into y position estimates.  Also avoid doing the comparison of
        the final position against the y position estimate until after the clear has happened.  This gets rid
        of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.

        Reviewed by Dan Bernstein

        Added fast/block/float/nested-clearance.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::collapseMargins):
        (WebCore::RenderBlock::clearFloatsIfNeeded):
        (WebCore::RenderBlock::estimateVerticalPosition):
        (WebCore::RenderBlock::layoutBlockChildren):
        (WebCore::RenderBlock::getClearDelta):
        * rendering/RenderBlock.h:

LayoutTests:

2009-03-03  David Hyatt  <hyatt@apple.com>

        Test case for https://bugs.webkit.org/show_bug.cgi?id=24201

        Reviewed by Dan Bernstein

        * fast/block/float/nested-clearance.html: Added.
        * platform/mac/fast/block/float/nested-clearance-expected.checksum: Added.
        * platform/mac/fast/block/float/nested-clearance-expected.png: Added.
        * platform/mac/fast/block/float/nested-clearance-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/block/float/nested-clearance.html [new file with mode: 0644]
LayoutTests/platform/mac/fast/block/float/nested-clearance-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/block/float/nested-clearance-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/block/float/nested-clearance-expected.txt [new file with mode: 0644]
WebCore/ChangeLog
WebCore/dom/Element.cpp
WebCore/rendering/RenderBlock.cpp
WebCore/rendering/RenderBlock.h