LayoutTests:
authorggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 31 Oct 2006 23:56:37 +0000 (23:56 +0000)
committerggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 31 Oct 2006 23:56:37 +0000 (23:56 +0000)
commitb06cf314e4b1906cab983ee173088e5c0bb2a136
tree40496f2c8bc2f33a68804d6c391742c2e97f2d1d
parent9c33d391de22db70bce88f781596839d91235c50
LayoutTests:

        Added layout test for copying password field.

        * editing/pasteboard/copy-in-password-field-expected.txt: Added.
        * editing/pasteboard/copy-in-password-field.html: Added.

WebCore:

        Reviewed by Alice.

        Moved some Editing code from WebKit, the bridge, and WebCore::Frame down
        to WebCore::Editor.

        Layout tests pass.

        Renamed "may*" to "can*" because "can" is more accurate (these functions
        aren't just about permission) and it matches WebKit.

        (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a
        password field. Now that WebCore fully implements canCopy(), it doesn't just
        mean "the selection is not in a password field" anymore.
        (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code.
        The fact that it's not called anymore may represent a security issue, but I
        don't see how commented-out code will help reveal the issue, and the
        bridge is going away, anyway.
        * editing/SelectionController.h: Changed selection() calls to references
        to m_sel, to match the rest of the file.

WebKit:

        Reviewed by Alice.

        Moved some Editing code from WebKit, the bridge, and WebCore::Frame down
        to WebCore::Editor.

        * WebCoreSupport/WebFrameBridge.mm:
        * WebView/WebHTMLView.m:
        (-[WebHTMLView _shouldDeleteRange:]):
        (-[WebHTMLView _canCopy]):
        (-[WebHTMLView _canCut]):
        (-[WebHTMLView _canDelete]):
        (-[WebHTMLView _canPaste]):
        (-[WebHTMLView _canEdit]):
        (-[WebHTMLView _canEditRichly]):
        (-[WebHTMLView _isEditable]):
        (-[WebHTMLView _isSelectionInPasswordField]):
        (-[NSArray validateUserInterfaceItem:]):
        (-[NSArray _expandSelectionToGranularity:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
22 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/pasteboard/copy-in-password-field-expected.txt [new file with mode: 0644]
LayoutTests/editing/pasteboard/copy-in-password-field.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/WebCore.exp
WebCore/bridge/EditorClient.h
WebCore/bridge/mac/FrameMac.h
WebCore/bridge/mac/FrameMac.mm
WebCore/bridge/mac/WebCoreFrameBridge.h
WebCore/bridge/mac/WebCoreFrameBridge.mm
WebCore/editing/CommandByName.cpp
WebCore/editing/Editor.cpp
WebCore/editing/Editor.h
WebCore/editing/JSEditor.cpp
WebCore/editing/SelectionController.cpp
WebCore/editing/SelectionController.h
WebCore/page/Frame.cpp
WebCore/page/Frame.h
WebCore/page/FrameView.cpp
WebKit/ChangeLog
WebKit/WebCoreSupport/WebFrameBridge.mm
WebKit/WebView/WebHTMLView.m