2006-04-26 Mitz Pettel <opendarwin.org@mitzpettel.com>
authoreseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 Apr 2006 21:23:53 +0000 (21:23 +0000)
committereseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 Apr 2006 21:23:53 +0000 (21:23 +0000)
commitaaff720236eaa49b3868c1db45385fdf864cf990
tree82e9255cf9fa45587634d0e14b8bde9425c1fcfd
parent7eff330cca194a65f535a61d2258cea63e93d487
2006-04-26  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed by darin.  Landed by eseidel.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8452
          mangleme(0x58c22e11): Random crashes

        Test: fast/frames/empty-cols-attribute.html

        * platform/StringImpl.cpp:
        (WebCore::StringImpl::toLengthArray): If the string is empty, return 0
        but set len to 1. This gives the same behavior you get if you don't specify
        the attribute at all, matching WinIE and Firefox. Previously, the empty
        string resulted in len being set to 0 (and a memory smasher in
        RenderFrameSet::layout()).
        * rendering/render_frames.cpp:
        (WebCore::RenderFrameSet::layout): Added an assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/fast/frames/empty-cols-attribute-expected.checksum [new file with mode: 0644]
LayoutTests/fast/frames/empty-cols-attribute-expected.txt [new file with mode: 0644]
LayoutTests/fast/frames/empty-cols-attribute.html [new file with mode: 0644]
WebCore/platform/StringImpl.cpp
WebCore/rendering/render_frames.cpp