2007-07-13 Mitz Pettel <mitz@webkit.org>
authorbdash <bdash@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 13 Jul 2007 11:51:40 +0000 (11:51 +0000)
committerbdash <bdash@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 13 Jul 2007 11:51:40 +0000 (11:51 +0000)
commita8da182426bb1d8ab3421dd30f2ffa1f026f5a98
treec0e771eacda2b2cf9a962c1950d1fa241325a23c
parent1c64ac158575ebff6efb731fd3a3bd9b73efb273
2007-07-13  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14395
          When a <p> is inside <li> two <BR>s are rendered

        Test: fast/lists/marker-before-empty-inline.html

        * rendering/RenderBlock.h:
        * rendering/RenderListItem.cpp:
        (WebCore::getParentOfFirstLineBox): Changed to skip empty inline flows that
        do not actually generate any line boxes. Limited the nested lists quirk to
        the case where the list is a child of the list item, to match Firefox.
        * rendering/bidi.cpp:
        (WebCore::requiresLineBox): Added. Factored out of skipWhitespace.
        (WebCore::RenderBlock::generatesLineBoxesForInlineChild): Added. Checkes
        whether the child or any of its siblings following it will generate a line
        box in the flow.
        (WebCore::RenderBlock::skipWhitespace):

2007-07-13  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14395
          When a <p> is inside <li> two <BR>s are rendered

        * editing/pasteboard/4861080-expected.checksum:
        * editing/pasteboard/4861080-expected.png:
        * editing/pasteboard/4861080-expected.txt:
        * fast/lists/marker-before-empty-inline-expected.checksum: Added.
        * fast/lists/marker-before-empty-inline-expected.png: Added.
        * fast/lists/marker-before-empty-inline-expected.txt: Added.
        * fast/lists/marker-before-empty-inline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
12 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/pasteboard/4861080-expected.checksum
LayoutTests/editing/pasteboard/4861080-expected.png
LayoutTests/editing/pasteboard/4861080-expected.txt
LayoutTests/fast/lists/marker-before-empty-inline-expected.checksum [new file with mode: 0644]
LayoutTests/fast/lists/marker-before-empty-inline-expected.png [new file with mode: 0644]
LayoutTests/fast/lists/marker-before-empty-inline-expected.txt [new file with mode: 0644]
LayoutTests/fast/lists/marker-before-empty-inline.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/rendering/RenderBlock.h
WebCore/rendering/RenderListItem.cpp
WebCore/rendering/bidi.cpp