LayoutTests:
authormjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Feb 2007 04:06:07 +0000 (04:06 +0000)
committermjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Feb 2007 04:06:07 +0000 (04:06 +0000)
commita84d2107e007f85a267f864646fe9c7cc640be1d
treec6ab791dd2a21ebe07fa33b2e482d2123adf3d2b
parent7e23eb8d1478b7a6cc1b302e86d1d97edb8a457c
LayoutTests:

        Reviewed by Maciej.

        - test for http://bugs.webkit.org/show_bug.cgi?id=10144
          REGRESSION: Reproducible assertion failure in DeleteSelectionCommand::fixupWhitespace()

        * fast/text/delete-hard-break-character-expected.checksum: Added.
        * fast/text/delete-hard-break-character-expected.png: Added.
        * fast/text/delete-hard-break-character-expected.txt: Added.
        * fast/text/delete-hard-break-character.html: Added.

WebCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=10144
          REGRESSION: Reproducible assertion failure in DeleteSelectionCommand::fixupWhitespace()

        Test: fast/text/delete-hard-break-character.html

        The bug was caused by not updating a line whose line break object and offset
        has been deleted. When deleting text, all lines containing the deleted text
        are marked dirty. However, if the first character being deleted is a newline
        which serves as a hard line break for the previous line, then that line will
        not be marked, and since it will be a clean line ending with a line break,
        relayout will begin at the next line. The fix is to check for this when
        determining where to relayout from.

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::determineStartPosition): Changed the condition for
        including the last clean line in relayout to include the case where the
        last clean line ends with a line break, but that line break is a newline that
        has been deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/text/delete-hard-break-character-expected.checksum [new file with mode: 0644]
LayoutTests/fast/text/delete-hard-break-character-expected.png [new file with mode: 0644]
LayoutTests/fast/text/delete-hard-break-character-expected.txt [new file with mode: 0644]
LayoutTests/fast/text/delete-hard-break-character.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/rendering/bidi.cpp