2006-05-13 Sam Weinig <sam.weinig@gmail.com>
authorap <ap@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 13 May 2006 14:58:24 +0000 (14:58 +0000)
committerap <ap@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 13 May 2006 14:58:24 +0000 (14:58 +0000)
commita61c12539fceb351ca60c8d5ffb9284c3f9ee6d6
tree46586dada71383e5fb88183db0a2ccb44e50f88b
parent220a3473b3ddbb8a407c5a7b614725794fd0e187
2006-05-13  Sam Weinig  <sam.weinig@gmail.com>

        Reviewed by Hyatt, landed by ap.

WebCore:
        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=7604
        calcAbsoluteHorizontalValues() is being getting passed arguments
        in the wrong order in calcAbsoluteHorizontal()

        Cleans up the RenderBox code for absolutely positioned elements
        and adds new functions for replaced absolutely positioned
        elements. Now uses Length so that magic number -666666 for
        auto lengths is no longer used.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteHorizontalValues):
        (WebCore::RenderBox::calcAbsoluteVertical):
        (WebCore::RenderBox::calcAbsoluteVerticalValues):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Handle replaced
        case separately.
        (WebCore::RenderBox::calcAbsoluteVerticalReplaced): ditto.
        * rendering/RenderBox.h:

LayoutTests:
        * fast/block/positioning/absolute-length-of-neg-666666.html: Added.
        * fast/block/positioning/absolute-positioned-overconstrained.html: Added.
        * fast/block/positioning/auto/006.html: Updated to reflect that the containing
        block's direction, not the parent's is used.
        * fast/css/absolute-poition-in-rtl-parent.html: Updated and cleaned up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
15 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/block/positioning/absolute-length-of-neg-666666-expected.checksum [new file with mode: 0644]
LayoutTests/fast/block/positioning/absolute-length-of-neg-666666-expected.png [new file with mode: 0644]
LayoutTests/fast/block/positioning/absolute-length-of-neg-666666-expected.txt [new file with mode: 0644]
LayoutTests/fast/block/positioning/absolute-length-of-neg-666666.html [new file with mode: 0644]
LayoutTests/fast/block/positioning/absolute-positioned-overconstrained-expected.checksum [new file with mode: 0644]
LayoutTests/fast/block/positioning/absolute-positioned-overconstrained-expected.png [new file with mode: 0644]
LayoutTests/fast/block/positioning/absolute-positioned-overconstrained-expected.txt [new file with mode: 0644]
LayoutTests/fast/block/positioning/absolute-positioned-overconstrained.html [new file with mode: 0644]
LayoutTests/fast/block/positioning/auto/006.html
LayoutTests/fast/css/absolute-poition-in-rtl-parent-expected.txt
LayoutTests/fast/css/absolute-poition-in-rtl-parent.html
WebCore/ChangeLog
WebCore/rendering/RenderBox.cpp
WebCore/rendering/RenderBox.h