2008-06-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
authorcwzwarich@webkit.org <cwzwarich@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 12 Jun 2008 09:03:41 +0000 (09:03 +0000)
committercwzwarich@webkit.org <cwzwarich@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 12 Jun 2008 09:03:41 +0000 (09:03 +0000)
commit91fc55c9ef3a1cf9f2e48dd66d3e0e265fa0560b
treee5f710c4ed262f86718034f2408e690b31bd3aba
parent54252b2d3f0e7db818597a9526c5c830db6688a0
2008-06-12  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Bug 19510: CodeBlock::needsFullScopeChain not always set for global code
        <https://bugs.webkit.org/show_bug.cgi?id=19510>

        This fixes the symptoms by using CodeGenerator::m_codeType to determine
        when to use temporaries instead of CodeBlock::needsFullScopeChain, but
        it does not fix the problem itself.

        JavaScriptCore:

        * VM/CodeGenerator.h:
        (KJS::CodeGenerator::leftHandSideNeedsCopy):

        LayoutTests:

        * fast/js/codegen-temporaries-multiple-global-blocks-expected.txt: Added.
        * fast/js/codegen-temporaries-multiple-global-blocks.html: Added.
        * fast/js/resources/codegen-temporaries-multiple-global-blocks-1.js: Added.
        * fast/js/resources/codegen-temporaries-multiple-global-blocks-2.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JavaScriptCore/ChangeLog
JavaScriptCore/VM/CodeGenerator.h
LayoutTests/ChangeLog
LayoutTests/fast/js/codegen-temporaries-multiple-global-blocks-expected.txt [new file with mode: 0644]
LayoutTests/fast/js/codegen-temporaries-multiple-global-blocks.html [new file with mode: 0644]
LayoutTests/fast/js/resources/codegen-temporaries-multiple-global-blocks-1.js [new file with mode: 0644]
LayoutTests/fast/js/resources/codegen-temporaries-multiple-global-blocks-2.js [new file with mode: 0644]