commit-queue should check for oops in changelog entries
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 21 May 2013 03:58:00 +0000 (03:58 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 21 May 2013 03:58:00 +0000 (03:58 +0000)
commit8ad9da84f82a945782ff0c2e7410a04c72ac794f
tree15dbf8ec65c1849d6c5083a1e7a726f4c889d501
parentdafe205d4dcd71c7fa6ffc71f9892b1d1018962e
commit-queue should check for oops in changelog entries
https://bugs.webkit.org/show_bug.cgi?id=116395

Reviewed by Martin Robinson.

Make changelog validation fail when it contains oops!.

* Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask._validate_changelog):
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(CommitQueueTaskTest._run_through_task):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/steps/validatechangelogs.py:
(ValidateChangeLogs.options):
(ValidateChangeLogs._check_changelog_diff):
(ValidateChangeLogs._changelog_contains_oops):
(ValidateChangeLogs.run):
* Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
(ValidateChangeLogsTest._assert_start_line_produces_output):
(ValidateChangeLogsTest.test_check_changelog_diff):
(ValidateChangeLogsTest):
(ValidateChangeLogsTest.test_changelog_contains_oops):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Tools/ChangeLog
Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py
Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
Tools/Scripts/webkitpy/tool/commands/queues_unittest.py
Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py
Tools/Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py