[chromium] Fix scaleDelta zoom-out visibility rect bug
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 15 Nov 2011 04:08:20 +0000 (04:08 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 15 Nov 2011 04:08:20 +0000 (04:08 +0000)
commit8a65ead25bf661e86070a90d009de5490d0cbc24
tree81eb2529429226e07eaa9a1398e3460ea3cab150
parent338a2599885c84d387d3548e57b0feaa3806a55c
[chromium] Fix scaleDelta zoom-out visibility rect bug
https://bugs.webkit.org/show_bug.cgi?id=72208

Since the scroll is no longer applied at the top layer of the layer
tree, the scaleDelta transformation needs to be moved down to the
same level.

Also fix zoomAnimator to be applied the same way.  I removed zoom
animator layout tests, as they aren't testing the actual impl-side
codepath, and are hard to continue supporting -- we should cover zoom
features with unit tests in the future.

Patch by Alexandre Elias <aelias@google.com> on 2011-11-14
Reviewed by James Robinson.

No new tests (planning to add later: https://bugs.webkit.org/show_bug.cgi?id=71529)

* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::scaleDelta):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::setScaleDelta):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::scaleDelta):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::setZoomAnimatorTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
21 files changed:
LayoutTests/platform/chromium-gpu-cg-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png [deleted file]
LayoutTests/platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png [deleted file]
LayoutTests/platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test2-expected.png [deleted file]
LayoutTests/platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png [deleted file]
LayoutTests/platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png [deleted file]
LayoutTests/platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test2-expected.png [deleted file]
LayoutTests/platform/chromium-gpu/platform/chromium/compositing/zoom-animator-scale-test-expected.txt [deleted file]
LayoutTests/platform/chromium/compositing/zoom-animator-scale-test.html [deleted file]
LayoutTests/platform/chromium/compositing/zoom-animator-scale-test2-expected.txt [deleted file]
LayoutTests/platform/chromium/compositing/zoom-animator-scale-test2.html [deleted file]
LayoutTests/platform/chromium/test_expectations.txt
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/chromium/LayerChromium.h
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp
Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h
Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp
Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
Source/WebKit/chromium/tests/CCLayerImplTest.cpp