WebCore:
authordarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 16 Dec 2007 19:26:02 +0000 (19:26 +0000)
committerdarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 16 Dec 2007 19:26:02 +0000 (19:26 +0000)
commit887ffb977d4c4e9ea92ea26bdc07f004fd147bb3
tree71d1b5f3bfb7489a7df4a81612cb367bb39c122d
parentbca72395e1bbcf39be6c25e9720b6acceba8e2f4
WebCore:

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=6129
        Incomplete implementation of CSS 2.1 system colors

        Test: fast/css/css2-system-color.html

        Based on original patch by Rob Buis.

        System colors are retrieved from NSColor as appropriate. If the color is a pattern color
        (and therefore NSColor won't let us retrieve a color from it) we draw a 1x1 image of the
        color and sample that to get a solid color.

        * css/CSSStyleSelector.cpp:
        (WebCore::):
        (WebCore::colorForCSSValue):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::systemColor):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::getSystemColor):
        (WebCore::RenderThemeMac::platformColorsDidChange):
        (WebCore::RenderThemeMac::systemColor):

LayoutTests:

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=6129
        Incomplete implementation of CSS 2.1 system colors

        Add layout test for this bug and update tests for new system-derived colors

        * fast/css/css2-system-color.html: Added.
        * platform/mac/fast/css/css2-system-color-expected.checksum: Added.
        * platform/mac/fast/css/css2-system-color-expected.png: Added.
        * platform/mac/fast/css/css2-system-color-expected.txt: Added.
        * platform/mac/fast/css/css2-system-fonts-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug103533-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
14 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/css/css2-system-color.html [new file with mode: 0644]
LayoutTests/platform/mac/fast/css/css2-system-color-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/css/css2-system-color-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/css/css2-system-color-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.checksum
LayoutTests/platform/mac/tables/mozilla/bugs/bug103533-expected.txt
WebCore/ChangeLog
WebCore/WebCore.xcodeproj/project.pbxproj
WebCore/css/CSSStyleSelector.cpp
WebCore/rendering/RenderTheme.cpp
WebCore/rendering/RenderTheme.h
WebCore/rendering/RenderThemeMac.h
WebCore/rendering/RenderThemeMac.mm