2009-04-30 Ojan Vafai <ojan@chromium.org>
authorojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Apr 2009 21:45:53 +0000 (21:45 +0000)
committerojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Apr 2009 21:45:53 +0000 (21:45 +0000)
commit82413431670580d8e4bf98137680711a9f3dcd7c
tree6fc896d6c2e8dbb6e36f52dbff3a598cbc7fa220
parenta56538c7ce03f71f2875ef9b3f73f9b843a3bae6
2009-04-30  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        Fix tests that depend on Mac-specific metrics now that text controls
        are sized according to font metrics (r43007).

        Fixes https://bugs.webkit.org/show_bug.cgi?id=25474.

        * fast/forms/textarea-appearance-wrap-expected.txt:
        * fast/forms/textarea-appearance-wrap.html:
        This test only really cares that a line-wrap character is submitted
        with forms that have the appropriate wrap value and not with other forms.
        So checking that the submit contents have a line-wrap character, instead of
        looking for it in a specific place, is sufficient. This gets around that we
        wrap in a different place in some cases on Mac and Windows.

        * fast/forms/textarea-hard-linewrap-expected.txt: Removed.
        * fast/forms/textarea-hard-linewrap.html: Removed.
        This test is redundant with fast/forms/textarea-appearance-wrap.html.

        * fast/replaced/table-percent-height-expected.txt:
        * fast/replaced/table-percent-height-text-controls-expected.txt: Added.
        * fast/replaced/table-percent-height-text-controls.html: Added.
        * fast/replaced/table-percent-height.html:
        Pulled out the cases in table-percent-height.html that had text controls and moved
        them into their own test. The new test doesn't assert specific metrics, it just
        spits them out. This allows us to have different expected results for Windows and
        Mac without having "FAIL" messages in the expected results. It's not perfect, but
        it seems better than any alternatives I could come up with. We do still print "FAIL"
        if the results don't match any platform.

        * platform/win/Skipped:
        * platform/win/fast/replaced/table-percent-height-text-controls-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/forms/textarea-appearance-wrap-expected.txt
LayoutTests/fast/forms/textarea-appearance-wrap.html
LayoutTests/fast/forms/textarea-hard-linewrap-expected.txt [deleted file]
LayoutTests/fast/forms/textarea-hard-linewrap.html [deleted file]
LayoutTests/fast/replaced/table-percent-height-expected.txt
LayoutTests/fast/replaced/table-percent-height-text-controls-expected.txt [new file with mode: 0644]
LayoutTests/fast/replaced/table-percent-height-text-controls.html [new file with mode: 0644]
LayoutTests/fast/replaced/table-percent-height.html
LayoutTests/platform/win/Skipped
LayoutTests/platform/win/fast/replaced/table-percent-height-text-controls-expected.txt [new file with mode: 0644]