LayoutTests:
authoradele <adele@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Mar 2006 01:49:57 +0000 (01:49 +0000)
committeradele <adele@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Mar 2006 01:49:57 +0000 (01:49 +0000)
commit8108a7a379d4963615d6d55da9179842e247fd93
tree4f8d69a63cc0cd8d2edd0495c8d29b9a693af579
parent480c5f4fee55c429fdbf1664e152f8b0912733e8
LayoutTests:

        Reviewed by Hyatt.

        Updated tests for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6986
        Switch to use new text field implementation for <input type="text">

        The new text field implementation uses RenderTextFielda instead of RenderLineEdits,
        and this accounts for many of the changes here.

        Also, background color and border properties are now dumped as part of the RenderTextField.

        There is also an outstanding bug that affects many tests that make a selection in a text field.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8068
        Editing delegate should not be notified when selection change involved new text field

        Now that we support box-sizing, we count border and padding when calculating size, so some
        of the tests that specify border size have different text field sizes.

        * editing/selection/3690703-2-expected.checksum:
        * editing/selection/3690703-2-expected.png:
        * editing/selection/3690703-2-expected.txt:
        * editing/selection/3690703-expected.checksum:
        * editing/selection/3690703-expected.png:
        * editing/selection/3690703-expected.txt:
        * editing/selection/3690719-expected.checksum:
        * editing/selection/3690719-expected.png:
        * editing/selection/3690719-expected.txt:
        * fast/block/float/032-expected.checksum:
        * fast/block/float/032-expected.png:
        * fast/block/float/032-expected.txt:
        * fast/block/margin-collapse/103-expected.txt:
        * fast/events/div-focus-expected.txt:
        * fast/events/event-sender-mouse-click-expected.txt:
        * fast/forms/access-key-expected.txt:
        * fast/forms/element-by-name-expected.txt:
        * fast/forms/focus-expected.txt:
        * fast/forms/form-element-geometry-expected.checksum:
        * fast/forms/form-element-geometry-expected.png:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/indeterminate-expected.checksum:
        * fast/forms/indeterminate-expected.png:
        * fast/forms/input-appearance-bkcolor-expected.checksum:
        * fast/forms/input-appearance-bkcolor-expected.png:
        * fast/forms/input-appearance-bkcolor-expected.txt:
        * fast/forms/input-appearance-default-bkcolor-expected.checksum:
        * fast/forms/input-appearance-default-bkcolor-expected.png:
        * fast/forms/input-appearance-default-bkcolor-expected.txt:
        * fast/forms/input-appearance-disabled-expected.checksum:
        * fast/forms/input-appearance-disabled-expected.png:
        * fast/forms/input-appearance-disabled-expected.txt:
        * fast/forms/input-appearance-focus-expected.checksum:
        * fast/forms/input-appearance-focus-expected.png:
        * fast/forms/input-appearance-focus-expected.txt:
        * fast/forms/input-appearance-maxlength-expected.txt:
        * fast/forms/input-appearance-maxlength.html:
        * fast/forms/input-appearance-minWidth-expected.checksum:
        * fast/forms/input-appearance-minWidth-expected.png:
        * fast/forms/input-appearance-minWidth-expected.txt:
        * fast/forms/input-appearance-preventDefault-expected.checksum:
        * fast/forms/input-appearance-preventDefault-expected.png:
        * fast/forms/input-appearance-preventDefault-expected.txt:
        * fast/forms/input-appearance-selection-expected.checksum:
        * fast/forms/input-appearance-selection-expected.png:
        * fast/forms/input-appearance-selection-expected.txt:
        * fast/forms/input-appearance-visibility-expected.checksum:
        * fast/forms/input-appearance-visibility-expected.png:
        * fast/forms/input-appearance-visibility-expected.txt:
        * fast/forms/input-appearance-width-expected.checksum:
        * fast/forms/input-appearance-width-expected.png:
        * fast/forms/input-appearance-width-expected.txt:
        * fast/forms/input-baseline-expected.checksum:
        * fast/forms/input-baseline-expected.png:
        * fast/forms/input-baseline-expected.txt:
        * fast/forms/input-changing-value-expected.txt:
        * fast/forms/input-value-expected.txt:
        * fast/forms/input-width-expected.txt:
        * fast/forms/legend-access-key-expected.txt:
        * fast/forms/selection-functions-expected.txt:
        * fast/forms/textfield-focus-out-expected.txt:
        * fast/replaced/width100percent-expected.checksum:
        * fast/replaced/width100percent-expected.png:
        * fast/replaced/width100percent-expected.txt:
        * fast/table/003-expected.txt:
        * fast/table/colspanMinWidth-expected.txt:
        * fast/table/spanOverlapRepaint-expected.txt:
        * tables/mozilla/bugs/45621-expected.txt:
        * tables/mozilla/bugs/bug1188-expected.checksum:
        * tables/mozilla/bugs/bug1188-expected.png:
        * tables/mozilla/bugs/bug1188-expected.txt:
        * tables/mozilla/bugs/bug12384-expected.checksum:
        * tables/mozilla/bugs/bug12384-expected.png:
        * tables/mozilla/bugs/bug12384-expected.txt:
        * tables/mozilla/bugs/bug18359-expected.checksum:
        * tables/mozilla/bugs/bug18359-expected.png:
        * tables/mozilla/bugs/bug18359-expected.txt:
        * tables/mozilla/bugs/bug24200-expected.txt:
        * tables/mozilla/bugs/bug2479-3-expected.txt:
        * tables/mozilla/bugs/bug2479-4-expected.txt:
        * tables/mozilla/bugs/bug28928-expected.txt:
        * tables/mozilla/bugs/bug4382-expected.txt:
        * tables/mozilla/bugs/bug4527-expected.txt:
        * tables/mozilla/bugs/bug46368-1-expected.txt:
        * tables/mozilla/bugs/bug46368-2-expected.txt:
        * tables/mozilla/bugs/bug51037-expected.txt:
        * tables/mozilla/bugs/bug55545-expected.checksum:
        * tables/mozilla/bugs/bug55545-expected.png:
        * tables/mozilla/bugs/bug55545-expected.txt:
        * tables/mozilla/bugs/bug59354-expected.txt:
        * tables/mozilla/bugs/bug7342-expected.checksum:
        * tables/mozilla/bugs/bug7342-expected.png:
        * tables/mozilla/bugs/bug7342-expected.txt:
        * tables/mozilla/bugs/bug96334-expected.checksum:
        * tables/mozilla/bugs/bug96334-expected.png:
        * tables/mozilla/bugs/bug96334-expected.txt:
        * tables/mozilla/bugs/bug99948-expected.txt:
        * tables/mozilla/dom/tableDom-expected.txt:
        * tables/mozilla/other/move_row-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.png:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug45621-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug45621-expected.png:
        * tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

WebCore:

        Reviewed by Hyatt.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6986
        Switch to use new text field implementation for <input type="text">

        * css/html4.css: Added default style info for new text fields.
        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::createDivStyle): Added an extra 1px of padding on the left & right to match Win IE & the latest Mozilla.
        (WebCore::RenderTextField::updateFromElement): Removed some outdated comments.  Cleaned up the way we add text nodes to the div.
        (WebCore::RenderTextField::setSelectionStart): Tweaked selection code to better match Mozilla behavior.
        (WebCore::RenderTextField::setSelectionEnd): ditto.
        (WebCore::RenderTextField::select): Cleaned this up by having it call setSelectionRange.
        (WebCore::RenderTextField::setSelectionRange): Calls updateLayout now in case this is called in an onload handler, and no other layout has occurred.
        (WebCore::RenderTextField::calcMinMaxWidth): Use floatWidth to calculate the width of the "0" character.
        * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): If the text field's specified border is different from
         the default border, then treat the control as styled, so the engine knows to turn off the aqua appearance.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintTextField): return false so the engine knows not to try to draw the border.
        (WebCore::RenderThemeMac::adjustTextFieldStyle): text field style info has been moved to html4.css.
         We also add intrinsic margins here if the font size is large enough.
        * html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler):
         No longer check for appearance. All text fields with m_type == TEXT will use the new implementation.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isKeyboardFocusable): ditto.
        (WebCore::HTMLInputElement::focus): ditto.
        (WebCore::HTMLInputElement::selectionStart): ditto.
        (WebCore::HTMLInputElement::selectionEnd): ditto.
        (WebCore::HTMLInputElement::setSelectionStart): ditto.
        (WebCore::HTMLInputElement::setSelectionEnd): ditto.
        (WebCore::HTMLInputElement::select): ditto.
        (WebCore::HTMLInputElement::setSelectionRange): ditto.
        (WebCore::HTMLInputElement::createRenderer): ditto.
        (WebCore::HTMLInputElement::defaultEventHandler): ditto.
        (WebCore::HTMLInputElement::isMouseFocusable): Added.  Old text fields relied on the widget to provide a focus policy.
         A text field that is focusable should be mouse focusable, and shouldn't need to ask the base class.
        * html/HTMLInputElement.h: Added isMouseFocusable.
        * html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isMouseFocusable):
         Removed specific text field code since that is now done in HTMLInputElement::isMouseFocusable.
        * dom/Document.cpp: (WebCore::Document::clearSelectionIfNeeded): Check that the new selection is does not have a shadowAncestorNode that is focused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
118 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/selection/3690703-2-expected.checksum
LayoutTests/editing/selection/3690703-2-expected.png
LayoutTests/editing/selection/3690703-2-expected.txt
LayoutTests/editing/selection/3690703-expected.checksum
LayoutTests/editing/selection/3690703-expected.png
LayoutTests/editing/selection/3690703-expected.txt
LayoutTests/editing/selection/3690719-expected.checksum
LayoutTests/editing/selection/3690719-expected.png
LayoutTests/editing/selection/3690719-expected.txt
LayoutTests/fast/block/float/032-expected.checksum
LayoutTests/fast/block/float/032-expected.png
LayoutTests/fast/block/float/032-expected.txt
LayoutTests/fast/block/margin-collapse/103-expected.txt
LayoutTests/fast/events/div-focus-expected.txt
LayoutTests/fast/events/event-sender-mouse-click-expected.txt
LayoutTests/fast/forms/access-key-expected.txt
LayoutTests/fast/forms/element-by-name-expected.txt
LayoutTests/fast/forms/focus-expected.txt
LayoutTests/fast/forms/form-element-geometry-expected.checksum
LayoutTests/fast/forms/form-element-geometry-expected.png
LayoutTests/fast/forms/form-element-geometry-expected.txt
LayoutTests/fast/forms/indeterminate-expected.checksum
LayoutTests/fast/forms/indeterminate-expected.png
LayoutTests/fast/forms/input-appearance-bkcolor-expected.checksum
LayoutTests/fast/forms/input-appearance-bkcolor-expected.png
LayoutTests/fast/forms/input-appearance-bkcolor-expected.txt
LayoutTests/fast/forms/input-appearance-default-bkcolor-expected.checksum
LayoutTests/fast/forms/input-appearance-default-bkcolor-expected.png
LayoutTests/fast/forms/input-appearance-default-bkcolor-expected.txt
LayoutTests/fast/forms/input-appearance-disabled-expected.checksum
LayoutTests/fast/forms/input-appearance-disabled-expected.png
LayoutTests/fast/forms/input-appearance-disabled-expected.txt
LayoutTests/fast/forms/input-appearance-focus-expected.checksum
LayoutTests/fast/forms/input-appearance-focus-expected.png
LayoutTests/fast/forms/input-appearance-focus-expected.txt
LayoutTests/fast/forms/input-appearance-maxlength-expected.txt
LayoutTests/fast/forms/input-appearance-maxlength.html
LayoutTests/fast/forms/input-appearance-minWidth-expected.checksum
LayoutTests/fast/forms/input-appearance-minWidth-expected.png
LayoutTests/fast/forms/input-appearance-minWidth-expected.txt
LayoutTests/fast/forms/input-appearance-preventDefault-expected.checksum
LayoutTests/fast/forms/input-appearance-preventDefault-expected.png
LayoutTests/fast/forms/input-appearance-preventDefault-expected.txt
LayoutTests/fast/forms/input-appearance-selection-expected.checksum
LayoutTests/fast/forms/input-appearance-selection-expected.png
LayoutTests/fast/forms/input-appearance-selection-expected.txt
LayoutTests/fast/forms/input-appearance-visibility-expected.checksum
LayoutTests/fast/forms/input-appearance-visibility-expected.png
LayoutTests/fast/forms/input-appearance-visibility-expected.txt
LayoutTests/fast/forms/input-appearance-width-expected.checksum
LayoutTests/fast/forms/input-appearance-width-expected.png
LayoutTests/fast/forms/input-appearance-width-expected.txt
LayoutTests/fast/forms/input-baseline-expected.checksum
LayoutTests/fast/forms/input-baseline-expected.png
LayoutTests/fast/forms/input-baseline-expected.txt
LayoutTests/fast/forms/input-changing-value-expected.txt
LayoutTests/fast/forms/input-value-expected.txt
LayoutTests/fast/forms/input-width-expected.txt
LayoutTests/fast/forms/legend-access-key-expected.txt
LayoutTests/fast/forms/selection-functions-expected.txt
LayoutTests/fast/forms/textfield-focus-out-expected.txt
LayoutTests/fast/replaced/width100percent-expected.checksum
LayoutTests/fast/replaced/width100percent-expected.png
LayoutTests/fast/replaced/width100percent-expected.txt
LayoutTests/fast/table/003-expected.txt
LayoutTests/fast/table/colspanMinWidth-expected.txt
LayoutTests/fast/table/spanOverlapRepaint-expected.txt
LayoutTests/tables/mozilla/bugs/45621-expected.txt
LayoutTests/tables/mozilla/bugs/bug1188-expected.checksum
LayoutTests/tables/mozilla/bugs/bug1188-expected.png
LayoutTests/tables/mozilla/bugs/bug1188-expected.txt
LayoutTests/tables/mozilla/bugs/bug12384-expected.checksum
LayoutTests/tables/mozilla/bugs/bug12384-expected.png
LayoutTests/tables/mozilla/bugs/bug12384-expected.txt
LayoutTests/tables/mozilla/bugs/bug18359-expected.checksum
LayoutTests/tables/mozilla/bugs/bug18359-expected.png
LayoutTests/tables/mozilla/bugs/bug18359-expected.txt
LayoutTests/tables/mozilla/bugs/bug24200-expected.txt
LayoutTests/tables/mozilla/bugs/bug2479-3-expected.txt
LayoutTests/tables/mozilla/bugs/bug2479-4-expected.txt
LayoutTests/tables/mozilla/bugs/bug28928-expected.txt
LayoutTests/tables/mozilla/bugs/bug4382-expected.txt
LayoutTests/tables/mozilla/bugs/bug4527-expected.txt
LayoutTests/tables/mozilla/bugs/bug46368-1-expected.txt
LayoutTests/tables/mozilla/bugs/bug46368-2-expected.txt
LayoutTests/tables/mozilla/bugs/bug51037-expected.txt
LayoutTests/tables/mozilla/bugs/bug55545-expected.checksum
LayoutTests/tables/mozilla/bugs/bug55545-expected.png
LayoutTests/tables/mozilla/bugs/bug55545-expected.txt
LayoutTests/tables/mozilla/bugs/bug59354-expected.txt
LayoutTests/tables/mozilla/bugs/bug7342-expected.checksum
LayoutTests/tables/mozilla/bugs/bug7342-expected.png
LayoutTests/tables/mozilla/bugs/bug7342-expected.txt
LayoutTests/tables/mozilla/bugs/bug96334-expected.checksum
LayoutTests/tables/mozilla/bugs/bug96334-expected.png
LayoutTests/tables/mozilla/bugs/bug96334-expected.txt
LayoutTests/tables/mozilla/bugs/bug99948-expected.txt
LayoutTests/tables/mozilla/dom/tableDom-expected.txt
LayoutTests/tables/mozilla/other/move_row-expected.txt
LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum
LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-2-expected.png
LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt
LayoutTests/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt
LayoutTests/tables/mozilla_expected_failures/bugs/bug45621-expected.checksum
LayoutTests/tables/mozilla_expected_failures/bugs/bug45621-expected.png
LayoutTests/tables/mozilla_expected_failures/bugs/bug45621-expected.txt
LayoutTests/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt
WebCore/ChangeLog
WebCore/css/html4.css
WebCore/dom/Document.cpp
WebCore/html/HTMLGenericFormElement.cpp
WebCore/html/HTMLInputElement.cpp
WebCore/html/HTMLInputElement.h
WebCore/html/HTMLTextFieldInnerElement.cpp
WebCore/rendering/RenderTextField.cpp
WebCore/rendering/RenderTheme.cpp
WebCore/rendering/RenderThemeMac.mm