WebKit:
authorsullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Oct 2004 17:52:07 +0000 (17:52 +0000)
committersullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Oct 2004 17:52:07 +0000 (17:52 +0000)
commit7ad9666d77717ed75fb3829dffb23dbb1aabecc7
tree0ca6fb101ac51e1dedd1d607a2d83402cd82aa0c
parent4b0c39124e8dd0691ff666fb91ee2d50f17ca42f
WebKit:

        Reviewed by Chris.

        - Cleanup from fix for <rdar://problem/3851676> bookmarks should not hold onto a WebHistoryItem object;
          eliminated notificationsSuppressed mechanism, which was used only by WebBookmark

        * History.subproj/WebHistoryItem.m:
        removed notificationsSuppressed ivar from private data object
        (-[WebHistoryItem setAlternateTitle:]):
        remove notificationsSuppressed guard
        (-[WebHistoryItem setURLString:]):
        ditto
        (-[WebHistoryItem setOriginalURLString:]):
        ditto
        (-[WebHistoryItem setTitle:]):
        ditto
        (-[WebHistoryItem _setLastVisitedTimeInterval:]):
        ditto
        (-[WebHistoryItem setNotificationsSuppressed:]):
        removed this method
        (-[WebHistoryItem notificationsSuppressed]):
        ditto

        * History.subproj/WebHistoryItemPrivate.h:
        removed notificationsSuppressed and setNotificationsSuppressed

WebBrowser:

        Reviewed by Chris.

        - fixed these bugs:
        <rdar://problem/3851676> bookmarks should not hold onto a WebHistoryItem object
        <rdar://problem/3852373> Could eliminate -[WebBookmark lastVisitedTimeInterval] for performance

        This reduced RPRVT after launch with the standard set of built-in bookmarks on my machine from
        4.12M to 4.09M, and sped up reading bookmarks a little also.

        * BrowserWebBookmarkExtras.m:
        (-[WebBookmark _goToWithWindowPolicy:]):
        Don't set lastVisitedTimeInterval here

        * URLCompletionController.m:
        (-[URLCompletionController _addStatsForURL:]):
        Added comment to this #defined-away method explaining that it wouldn't work as-is anymore
        since it calls the obsolete setLastVisitedTimeInterval

        * WebBookmark.h:
        remove lastVisitedTimeInterval and setLastVisitedTimeInterval

        * WebBookmark.m:
        removed _URL, setLastVisitedTimeInterval, and lastVisitedTimeInterval

        * WebBookmarkExporter.m:
        (-[WebBookmarkExporter stringForBookmarkLeaf:withIndentLevel:]):
        Don't export last visited time anymore

        * WebBookmarkGroup.m:
        (-[WebBookmarkGroup _addBookmarkToURLStringDictionary:]):
        use [bookmark URLString] instead of [bookmark _URL]. The latter was getting the URL from its
        WebHistoryItem, which no longer exists.

        * WebBookmarkLeaf.h:
        remove _entry ivar, add _title ivar
        * WebBookmarkLeaf.m:
        (-[WebBookmarkLeaf init]):
        removed this method, which set up _entry
        (-[WebBookmarkLeaf initWithURLString:title:group:]):
        weaned from _entry, also calls setURLString instead of setting the ivar directly to
        ensure that the WebIconDatabase is updated properly
        (-[WebBookmarkLeaf initFromDictionaryRepresentation:topLevelOnly:withGroup:]):
        ditto
        (-[WebBookmarkLeaf dictionaryRepresentation]):
        weaned from _entry
        (-[WebBookmarkLeaf dealloc]):
        calls setURLString instead of setting the ivar directly to ensure that the WebIconDatabase
        is updated properly
        (-[WebBookmarkLeaf copyWithZone:]):
        ditto
        (-[WebBookmarkLeaf title]):
        weaned from _entry
        (-[WebBookmarkLeaf setTitle:]):
        ditto
        (-[WebBookmarkLeaf icon]):
        ditto
        (-[WebBookmarkLeaf URLString]):
        ditto
        (-[WebBookmarkLeaf setURLString:]):
        ditto, also updates WebIconDatabase
        (-[WebBookmarkLeaf setLastVisitedTimeInterval:]):
        removed this method
        (-[WebBookmarkLeaf lastVisitedTimeInterval]):
        ditto
        (-[WebBookmarkLeaf _computeIsRSSBookmark]):
        use isSyndicationURLString on a string instead of isSyndicationURL on a URL

        * WebBookmarkPrivate.h:
        removed _URL method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@7886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit/ChangeLog
WebKit/History.subproj/WebHistoryItem.m
WebKit/History.subproj/WebHistoryItemPrivate.h