[OS X] Upright vertical text is completely broken for multi-code-unit codepoints
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Nov 2014 01:35:09 +0000 (01:35 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Nov 2014 01:35:09 +0000 (01:35 +0000)
commit7924a9319003dd76b196ec235e94195c61d5724d
tree8ca66218e2b75dd176ed46e84b1ae0d50b27afc5
parentf074414e6a71b8fa6501b1174045a66e18f03782
[OS X] Upright vertical text is completely broken for multi-code-unit codepoints
https://bugs.webkit.org/show_bug.cgi?id=138891

Reviewed by Dan Bernstein.

Source/WebCore:

We were assuming that we can use the string index (in UTF-16) as the glyph
index. This falls down when a single codepoint (and glyph) contians
multiple code units.

Test: platform/mac/fast/text/multiple-codeunit-vertical-upright.html

* platform/graphics/GlyphPage.h:
* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::GlyphPage::fill):

LayoutTests:

Make sure a single upright vertical multi-code-unit codepoint is rendered the same as
the same codepoint rendered horizontally.

* platform/mac/fast/text/multiple-codeunit-vertical-upright-expected.html: Added.
* platform/mac/fast/text/multiple-codeunit-vertical-upright.html: Added.
* platform/mac/fast/text/resources/multiple-codeunit-vertical-upright.otf: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/platform/mac/fast/text/multiple-codeunit-vertical-upright-expected.html [new file with mode: 0644]
LayoutTests/platform/mac/fast/text/multiple-codeunit-vertical-upright.html [new file with mode: 0644]
LayoutTests/platform/mac/fast/text/resources/multiple-codeunit-vertical-upright.otf [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/GlyphPage.h
Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp