Scrolling to anchor tags does nothing in vertical-rl writing mode
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Dec 2014 01:02:29 +0000 (01:02 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Dec 2014 01:02:29 +0000 (01:02 +0000)
commit73e822fb44595f3b6ee308ab7dfdc93a3099cc31
treef71fa1ccbec996b246f1a84cb04ef650abdc4707
parent5c6acdd5a3ce22590389bb387de6963804a34291
Scrolling to anchor tags does nothing in vertical-rl writing mode
https://bugs.webkit.org/show_bug.cgi?id=137838

Reviewed by David Hyatt.

Source/WebCore:

Scroll to a particular tag, and make sure the viewport is rendered as expected.

Tests: fast/events/scroll-to-anchor-vertical-lr-writing-mode.html
       fast/events/scroll-to-anchor-vertical-writing-mode-contained-2.html
       fast/events/scroll-to-anchor-vertical-writing-mode-contained.html
       fast/events/scroll-to-anchor-vertical-writing-mode.html

* page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
* rendering/ScrollBehavior.cpp:
* rendering/ScrollBehavior.h:

LayoutTests:

When we specify the behavior regarding scrolling to anchor tags, we previously had
only described behavior regarding horizontal text. When we have vertical text, we
need to switch the horizontal and vertical scrolling policies.

* fast/events/scroll-to-anchor-vertical-lr-writing-mode-expected.html: Added.
* fast/events/scroll-to-anchor-vertical-lr-writing-mode.html: Added.
* fast/events/scroll-to-anchor-vertical-writing-mode-contained-2-expected.html: Added.
* fast/events/scroll-to-anchor-vertical-writing-mode-contained-2.html: Added.
* fast/events/scroll-to-anchor-vertical-writing-mode-contained-expected.html: Added.
* fast/events/scroll-to-anchor-vertical-writing-mode-contained.html: Added.
* fast/events/scroll-to-anchor-vertical-writing-mode-expected.html: Added.
* fast/events/scroll-to-anchor-vertical-writing-mode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
13 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/events/scroll-to-anchor-vertical-lr-writing-mode-expected.html [new file with mode: 0644]
LayoutTests/fast/events/scroll-to-anchor-vertical-lr-writing-mode.html [new file with mode: 0644]
LayoutTests/fast/events/scroll-to-anchor-vertical-writing-mode-contained-2-expected.html [new file with mode: 0644]
LayoutTests/fast/events/scroll-to-anchor-vertical-writing-mode-contained-2.html [new file with mode: 0644]
LayoutTests/fast/events/scroll-to-anchor-vertical-writing-mode-contained-expected.html [new file with mode: 0644]
LayoutTests/fast/events/scroll-to-anchor-vertical-writing-mode-contained.html [new file with mode: 0644]
LayoutTests/fast/events/scroll-to-anchor-vertical-writing-mode-expected.html [new file with mode: 0644]
LayoutTests/fast/events/scroll-to-anchor-vertical-writing-mode.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/page/FrameView.cpp
Source/WebCore/rendering/ScrollBehavior.cpp
Source/WebCore/rendering/ScrollBehavior.h