Reviewed by Dave.
authordarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 31 Mar 2004 01:51:48 +0000 (01:51 +0000)
committerdarin <darin@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 31 Mar 2004 01:51:48 +0000 (01:51 +0000)
commit6cb363eaed79a81ce4cccebbd600f724548064ed
tree9a8664ec12874f59e20ac94df6d522422f932bf4
parent4c5d369db4799d8437377df75d00ba52411d8b84
    Reviewed by Dave.

        - fixed <rdar://problem/3570877>: REGRESSION: onfocus handler not working at weather.com

        * khtml/ecma/kjs_binding.cpp:
        (UString::string): Turn a null UString into a null DOMString, but a non-null empty UString into a
        non-null empty DOMString.
        (UString::qstring): Ditto, for QString.
        (Identifier::string): Ditto, for Identifier.
        (Identifier::qstring): Ditto.

        * kwq/KWQLineEdit.h: Override focusPolicy.
        * kwq/KWQLineEdit.mm: (QLineEdit::focusPolicy): Return StrongFocus instead of TabFocus, since
        we allow clicking to focus on these widgets.
        * kwq/KWQTextEdit.h: More of the same.
        * kwq/KWQTextEdit.mm: (QTextEdit::focusPolicy): And still more.

        - fixed <rdar://problem/3605919>: text fields in web pages are too tall

        * kwq/KWQTextField.mm:
        (-[KWQTextFieldCell _typesetterBehavior]): Ignore the per-application typesetter setting and
        instead always use the latest behavior for text fields in web pages.
        (-[KWQSecureTextFieldCell _typesetterBehavior]): Ditto.
        (-[KWQSearchFieldCell _typesetterBehavior]): Ditto.

        - additional cleanup

        * khtml/html/html_formimpl.cpp:
        (HTMLGenericFormElementImpl::isKeyboardFocusable): Check tab focus bit instead of different modes.
        (HTMLGenericFormElementImpl::isMouseFocusable): Check click focus bit instead of different modes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@6280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
13 files changed:
LayoutTests/css1/text_properties/text-transform-expected.txt
LayoutTests/fast/block/margin-collapse/103-expected.txt
LayoutTests/fast/forms/form-element-geometry-expected.txt
LayoutTests/fast/forms/input-width-expected.txt
LayoutTests/fast/table/003-expected.txt
WebCore/ChangeLog-2005-08-23
WebCore/khtml/ecma/kjs_binding.cpp
WebCore/khtml/html/html_formimpl.cpp
WebCore/kwq/KWQLineEdit.h
WebCore/kwq/KWQLineEdit.mm
WebCore/kwq/KWQTextEdit.h
WebCore/kwq/KWQTextEdit.mm
WebCore/kwq/KWQTextField.mm