LayoutTests:
authormjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 29 Mar 2007 01:17:07 +0000 (01:17 +0000)
committermjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 29 Mar 2007 01:17:07 +0000 (01:17 +0000)
commit682c0c07b30c5a1fd8cf3d7b20a9f25727d924d9
tree9e49fef245171e2548cd7a7e81eee36456fc2a03
parent3125149bf75378648324eeec77b4503aa164ee37
LayoutTests:

        Reviewed by Darin.

        - <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)

        * fast/overflow/scrollRevealButton-expected.checksum:
        * fast/overflow/scrollRevealButton-expected.png:
        * fast/overflow/scrollRevealButton-expected.txt:

WebCore:

        Reviewed by Darin.

        - fixed <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)

        Handle scrolling external scrollviews around the webview during
        autoscroll or when scrolling into view.

        This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollRectIntoViewRecursively):
        * page/FrameView.h:
        * platform/ScrollView.h:
        * platform/gdk/ScrollViewGdk.cpp:
        (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
        (WebCore::ScrollView::scrollRectIntoViewRecursively):
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::visibleContentRect):
        (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
        (WebCore::ScrollView::scrollRectIntoViewRecursively):
        (WebCore::ScrollView::updateContents):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
        (WebCore::ScrollView::scrollRectIntoViewRecursively):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::ScrollView::scrollRectIntoViewRecursively):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
14 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/overflow/scrollRevealButton-expected.checksum
LayoutTests/fast/overflow/scrollRevealButton-expected.png
LayoutTests/fast/overflow/scrollRevealButton-expected.txt
WebCore/ChangeLog
WebCore/page/FrameView.cpp
WebCore/page/FrameView.h
WebCore/platform/ScrollView.h
WebCore/platform/gdk/ScrollViewGdk.cpp
WebCore/platform/mac/ScrollViewMac.mm
WebCore/platform/qt/ScrollViewQt.cpp
WebCore/platform/win/ScrollViewWin.cpp
WebCore/platform/win/TemporaryLinkStubs.cpp
WebCore/rendering/RenderLayer.cpp